Update and pin github actions to full SHAs for supply chain security#3185
Merged
zuiderkwast merged 3 commits intovalkey-io:unstablefrom Feb 12, 2026
Merged
Update and pin github actions to full SHAs for supply chain security#3185zuiderkwast merged 3 commits intovalkey-io:unstablefrom
zuiderkwast merged 3 commits intovalkey-io:unstablefrom
Conversation
Signed-off-by: Rain Valentine <rsg000@gmail.com>
Contributor
|
While we're doing this, shall we also lift to the latest version in all jobs? 6.0.2 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3185 +/- ##
============================================
- Coverage 74.90% 0 -74.91%
============================================
Files 129 0 -129
Lines 71327 0 -71327
============================================
- Hits 53429 0 -53429
+ Misses 17898 0 -17898 🚀 New features to boost your workflow:
|
dvkashapov
approved these changes
Feb 11, 2026
Signed-off-by: Rain Valentine <rsg000@gmail.com>
zuiderkwast
reviewed
Feb 11, 2026
Contributor
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
Did the update of taiki-e/install-action make our spellcheck fail?
Contributor
Author
|
I think the updated spellchecker is just more picky. I guess I'll fix things up 😓 |
rainsupreme
force-pushed
the
action-shas
branch
2 times, most recently
from
b220d3b to
fd9784a
Compare
Signed-off-by: Rain Valentine <rsg000@gmail.com>
rainsupreme
force-pushed
the
action-shas
branch
from
fd9784a to
ef36108
Compare
Contributor
Sounds good. Otherwise, perhaps we can stay on the older minor version, just update to the latest patch version. |
Contributor
Author
|
The test failure looks unrelated to my changes, right? Could we rerun it or ignore it maybe? |
zuiderkwast
approved these changes
Feb 12, 2026
zuiderkwast
changed the title
zuiderkwast
changed the title
Contributor
|
When we backport this, we can skip lifting the spell checker to the latest version, if fixing the spelling causes merge conflicts. |
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 17, 2026
…alkey-io#3185) Updates to latest versions for each of the github actions used. Pinning prevents an attack where the upstream action dependency is compromised and the "v4" tag for example gets edited to point to a malicious version. We already do this for most checkout actions in our workflows. --------- Signed-off-by: Rain Valentine <rsg000@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 17, 2026
…alkey-io#3185) Updates to latest versions for each of the github actions used. Pinning prevents an attack where the upstream action dependency is compromised and the "v4" tag for example gets edited to point to a malicious version. We already do this for most checkout actions in our workflows. --------- Signed-off-by: Rain Valentine <rsg000@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 17, 2026
…alkey-io#3185) Updates to latest versions for each of the github actions used. Pinning prevents an attack where the upstream action dependency is compromised and the "v4" tag for example gets edited to point to a malicious version. We already do this for most checkout actions in our workflows. --------- Signed-off-by: Rain Valentine <rsg000@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 18, 2026
…alkey-io#3185) Updates to latest versions for each of the github actions used. Pinning prevents an attack where the upstream action dependency is compromised and the "v4" tag for example gets edited to point to a malicious version. We already do this for most checkout actions in our workflows. --------- Signed-off-by: Rain Valentine <rsg000@gmail.com>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 18, 2026
…alkey-io#3185) Updates to latest versions for each of the github actions used. Pinning prevents an attack where the upstream action dependency is compromised and the "v4" tag for example gets edited to point to a malicious version. We already do this for most checkout actions in our workflows. --------- Signed-off-by: Rain Valentine <rsg000@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
roshkhatri
added a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 18, 2026
…alkey-io#3185) Updates to latest versions for each of the github actions used. Pinning prevents an attack where the upstream action dependency is compromised and the "v4" tag for example gets edited to point to a malicious version. Also fixes typos in source code and test files. (cherry picked from commit 9cbe104) Adapted for 7.2: skipped files not present in this branch. Signed-off-by: Rain Valentine <rsg000@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
roshkhatri
added a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 19, 2026
…alkey-io#3185) Updates to latest versions for each of the github actions used. Pinning prevents an attack where the upstream action dependency is compromised and the "v4" tag for example gets edited to point to a malicious version. Also fixes typos in source code and test files. (cherry picked from commit 9cbe104) Adapted for 7.2: skipped files not present in this branch. Signed-off-by: Rain Valentine <rsg000@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
harrylin98
pushed a commit
to harrylin98/valkey_forked
that referenced
this pull request
Feb 19, 2026
…alkey-io#3185) Updates to latest versions for each of the github actions used. Pinning prevents an attack where the upstream action dependency is compromised and the "v4" tag for example gets edited to point to a malicious version. We already do this for most checkout actions in our workflows. --------- Signed-off-by: Rain Valentine <rsg000@gmail.com>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 20, 2026
…alkey-io#3185) Updates to latest versions for each of the github actions used. Pinning prevents an attack where the upstream action dependency is compromised and the "v4" tag for example gets edited to point to a malicious version. We already do this for most checkout actions in our workflows. --------- Signed-off-by: Rain Valentine <rsg000@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 20, 2026
…alkey-io#3185) Updates to latest versions for each of the github actions used. Pinning prevents an attack where the upstream action dependency is compromised and the "v4" tag for example gets edited to point to a malicious version. We already do this for most checkout actions in our workflows. --------- Signed-off-by: Rain Valentine <rsg000@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 20, 2026
…alkey-io#3185) Updates to latest versions for each of the github actions used. Pinning prevents an attack where the upstream action dependency is compromised and the "v4" tag for example gets edited to point to a malicious version. We already do this for most checkout actions in our workflows. --------- Signed-off-by: Rain Valentine <rsg000@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
roshkhatri
added a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 23, 2026
…alkey-io#3185) Updates to latest versions for each of the github actions used. Pinning prevents an attack where the upstream action dependency is compromised and the "v4" tag for example gets edited to point to a malicious version. Also fixes typos in source code and test files. (cherry picked from commit 9cbe104) Adapted for 7.2: skipped files not present in this branch. Signed-off-by: Rain Valentine <rsg000@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
hpatro
pushed a commit
that referenced
this pull request
Feb 24, 2026
…3185) Updates to latest versions for each of the github actions used. Pinning prevents an attack where the upstream action dependency is compromised and the "v4" tag for example gets edited to point to a malicious version. Also fixes typos in source code and test files. (cherry picked from commit 9cbe104) Adapted for 7.2: skipped files not present in this branch. Signed-off-by: Rain Valentine <rsg000@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to latest versions for each of the github actions used.
Pinning prevents an attack where the upstream action dependency is compromised and the "v4" tag for example gets edited to point to a malicious version. We already do this for most checkout actions in our workflows. (most, currently. I'm fixing that in my libbacktrace PR #3034 )