Allow some tags only on top level to fix --tags filtering#3171
Merged
zuiderkwast merged 6 commits intovalkey-io:unstablefrom Feb 9, 2026
Merged
Allow some tags only on top level to fix --tags filtering#3171zuiderkwast merged 6 commits intovalkey-io:unstablefrom
--tags filtering#3171zuiderkwast merged 6 commits intovalkey-io:unstablefrom
Conversation
Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com>
Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com>
zuiderkwast
reviewed
Feb 6, 2026
Contributor
There was a problem hiding this comment.
Awesome. Please also mention in the top comment the problem test case that didn't run in any of our Daily and CI because how --tags -large-memory skipped it and --tags large-memory missed the nested tag because it was under another tag that got skipped.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3171 +/- ##
============================================
+ Coverage 74.96% 74.98% +0.01%
============================================
Files 129 129
Lines 71318 71320 +2
============================================
+ Hits 53467 53481 +14
+ Misses 17851 17839 -12 🚀 New features to boost your workflow:
|
zuiderkwast
reviewed
Feb 6, 2026
Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech> Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com>
Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com>
Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com>
Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com>
zuiderkwast
approved these changes
Feb 9, 2026
Contributor
zuiderkwast
left a comment
There was a problem hiding this comment.
Very good, this should prevent tests from being always-skipped in the future.
harrylin98
pushed a commit
to harrylin98/valkey_forked
that referenced
this pull request
Feb 19, 2026
…o#3171) The problem: when running `./runtest --large-memory --tags large-memory` the `--tags large-memory` filter would look for tests with `large-memory` tag, it found the nested tag in the test context but `start_server` didn't have `large-memory`, so the filtering logic had issues. And that's why we did not notice how we introduced this failure: ``` [err]: CVE-2025-32023: Sparse HLL XZERO overflow triggers crash in tests/unit/hyperloglog.tcl Expected an error matching '*INVALIDOBJ*' but got '1' (context: type eval line 24 cmd {assert_error {*INVALIDOBJ*} {r pfadd hll_overflow foo}} proc ::test) ``` Tags `large-memory`, `needs:other-server`, `compatible-redis`, and `network` now restricted to top-level `start_server`. Prevents `--tags` filtering issues when these tags appear in nested contexts. Added validation that errors on nested usage. Refactored tests that fail new validation. Also fixed all `lsearch` calls to use `-exact` flag to preventing bugs like "tls" matching "tls:skip". --------- Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com> Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem: when running
./runtest --large-memory --tags large-memorythe--tags large-memoryfilter would look for tests withlarge-memorytag, it found the nested tag in the test context butstart_serverdidn't havelarge-memory, so the filtering logic had issues. And that's why we did not notice how we introduced this failure:Tags
large-memory,needs:other-server,compatible-redis, andnetworknow restricted to top-levelstart_server. Prevents--tagsfiltering issues when these tags appear in nested contexts. Added validation that errors on nested usage. Refactored tests that fail new validation. Also fixed alllsearchcalls to use-exactflag to preventing bugs like "tls" matching "tls:skip".