Add remaining_repl_size field in CLUSTER GETSLOTMIGRATIONS output#3135
Merged
enjoy-binbin merged 3 commits intovalkey-io:unstablefrom Feb 10, 2026
Merged
Add remaining_repl_size field in CLUSTER GETSLOTMIGRATIONS output#3135enjoy-binbin merged 3 commits intovalkey-io:unstablefrom
enjoy-binbin merged 3 commits intovalkey-io:unstablefrom
Conversation
There should be a way for people to monitor the amount of output buffer data accumulating at the source node during the migration process. Signed-off-by: Binbin <binloveplay1314@qq.com>
enjoy-binbin
commented
Jan 30, 2026
Signed-off-by: Binbin <binloveplay1314@qq.com>
murphyjacob4
approved these changes
Jan 30, 2026
Contributor
|
Seems like it will be useful. @enjoy-binbin do you know if this constitutes a major decision? I guess we count Edit: I see you added the tag already 🙂 |
Signed-off-by: Binbin <binloveplay1314@qq.com>
dvkashapov
approved these changes
Jan 30, 2026
Member
Author
|
@valkey-io/core-team please take a look and approve this new field. |
madolson
added
needs-doc-pr
zuiderkwast
approved these changes
Feb 3, 2026
enjoy-binbin
added
the
release-notes
enjoy-binbin
changed the title
enjoy-binbin
added a commit
to enjoy-binbin/valkey
that referenced
this pull request
Feb 10, 2026
In valkey-io#3135, it was incorrectly written as CLUSTER MIGRATESLOTS, it should be CLUSTE GETSLOTMIGRATIONS. Signed-off-by: Binbin <binloveplay1314@qq.com>
This was referenced Feb 10, 2026
harrylin98
pushed a commit
to harrylin98/valkey_forked
that referenced
this pull request
Feb 19, 2026
…io#3135) There should be a way for people to monitor the amount of output buffer data accumulating at the source node during the migration process. This PR also do a change in slotExportTryDoPause, previously, we used `getClientOutputBufferMemoryUsage` to determine if the offset was sufficient to trigger the pause, it also adding the listNode overhead. Now we use client->bytes. Signed-off-by: Binbin <binloveplay1314@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There should be a way for people to monitor the amount of output buffer
data accumulating at the source node during the migration process.
This PR also do a change in slotExportTryDoPause, previously, we used
getClientOutputBufferMemoryUsageto determine if the offset was sufficientto trigger the pause, it also adding the listNode overhead. Now we use
client->bytes.