Add waits in test-ubuntu-reclaim-cache#3134
Conversation
Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3134 +/- ##
============================================
+ Coverage 74.69% 74.84% +0.15%
============================================
Files 129 129
Lines 71199 71199
============================================
+ Hits 53185 53292 +107
+ Misses 18014 17907 -107 🚀 New features to boost your workflow:
|
|
Somehow those changes did not apply to CI run with run-extra-tests label |
Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com>
|
It seems it didn't pass even with the sleep. In the beginning of the job, maybe we need a sleep too, before these two valkey-cli? |
|
I added sleep exactly between those sever and cli launches, IDK how they did not execute and did not get logged |
zuiderkwast
left a comment
There was a problem hiding this comment.
I added sleep exactly between those sever and cli launches, IDK how they did not execute and did not get logged
I believe the workflow is using the unstable branch, but it checks out the code from the PR branch. That means that changes to the yaml file itself doesn't run until I merge it.
After valkey-io#3103 time sensitive `test-ubuntu-reclaim-cache` started to fail because now startup always includes 30ms of calibration of HW clock, that's why we get this output: ``` Run echo "test SAVE doesn't increase cache" test SAVE doesn't increase cache 2460491776 Could not connect to Valkey at 127.0.0.1:8080: Connection refused ``` Added waits for server to start, locally run, it helps --------- Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com>
After valkey-io#3103 time sensitive `test-ubuntu-reclaim-cache` started to fail because now startup always includes 30ms of calibration of HW clock, that's why we get this output: ``` Run echo "test SAVE doesn't increase cache" test SAVE doesn't increase cache 2460491776 Could not connect to Valkey at 127.0.0.1:8080: Connection refused ``` Added waits for server to start, locally run, it helps --------- Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
After valkey-io#3103 time sensitive `test-ubuntu-reclaim-cache` started to fail because now startup always includes 30ms of calibration of HW clock, that's why we get this output: ``` Run echo "test SAVE doesn't increase cache" test SAVE doesn't increase cache 2460491776 Could not connect to Valkey at 127.0.0.1:8080: Connection refused ``` Added waits for server to start, locally run, it helps --------- Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
After valkey-io#3103 time sensitive `test-ubuntu-reclaim-cache` started to fail because now startup always includes 30ms of calibration of HW clock, that's why we get this output: ``` Run echo "test SAVE doesn't increase cache" test SAVE doesn't increase cache 2460491776 Could not connect to Valkey at 127.0.0.1:8080: Connection refused ``` Added waits for server to start, locally run, it helps --------- Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
After valkey-io#3103 time sensitive `test-ubuntu-reclaim-cache` started to fail because now startup always includes 30ms of calibration of HW clock, that's why we get this output: ``` Run echo "test SAVE doesn't increase cache" test SAVE doesn't increase cache 2460491776 Could not connect to Valkey at 127.0.0.1:8080: Connection refused ``` Added waits for server to start, locally run, it helps --------- Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
After valkey-io#3103 time sensitive `test-ubuntu-reclaim-cache` started to fail because now startup always includes 30ms of calibration of HW clock, that's why we get this output: ``` Run echo "test SAVE doesn't increase cache" test SAVE doesn't increase cache 2460491776 Could not connect to Valkey at 127.0.0.1:8080: Connection refused ``` Added waits for server to start, locally run, it helps --------- Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
After valkey-io#3103 time sensitive `test-ubuntu-reclaim-cache` started to fail because now startup always includes 30ms of calibration of HW clock, that's why we get this output: ``` Run echo "test SAVE doesn't increase cache" test SAVE doesn't increase cache 2460491776 Could not connect to Valkey at 127.0.0.1:8080: Connection refused ``` Added waits for server to start, locally run, it helps --------- Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
After valkey-io#3103 time sensitive `test-ubuntu-reclaim-cache` started to fail because now startup always includes 30ms of calibration of HW clock, that's why we get this output: ``` Run echo "test SAVE doesn't increase cache" test SAVE doesn't increase cache 2460491776 Could not connect to Valkey at 127.0.0.1:8080: Connection refused ``` Added waits for server to start, locally run, it helps --------- Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
After valkey-io#3103 time sensitive `test-ubuntu-reclaim-cache` started to fail because now startup always includes 30ms of calibration of HW clock, that's why we get this output: ``` Run echo "test SAVE doesn't increase cache" test SAVE doesn't increase cache 2460491776 Could not connect to Valkey at 127.0.0.1:8080: Connection refused ``` Added waits for server to start, locally run, it helps --------- Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com>
After valkey-io#3103 time sensitive `test-ubuntu-reclaim-cache` started to fail because now startup always includes 30ms of calibration of HW clock, that's why we get this output: ``` Run echo "test SAVE doesn't increase cache" test SAVE doesn't increase cache 2460491776 Could not connect to Valkey at 127.0.0.1:8080: Connection refused ``` Added waits for server to start, locally run, it helps --------- Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
After #3103 time sensitive `test-ubuntu-reclaim-cache` started to fail because now startup always includes 30ms of calibration of HW clock, that's why we get this output: ``` Run echo "test SAVE doesn't increase cache" test SAVE doesn't increase cache 2460491776 Could not connect to Valkey at 127.0.0.1:8080: Connection refused ``` Added waits for server to start, locally run, it helps --------- Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
After #3103 time sensitive `test-ubuntu-reclaim-cache` started to fail because now startup always includes 30ms of calibration of HW clock, that's why we get this output: ``` Run echo "test SAVE doesn't increase cache" test SAVE doesn't increase cache 2460491776 Could not connect to Valkey at 127.0.0.1:8080: Connection refused ``` Added waits for server to start, locally run, it helps --------- Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
After #3103 time sensitive `test-ubuntu-reclaim-cache` started to fail because now startup always includes 30ms of calibration of HW clock, that's why we get this output: ``` Run echo "test SAVE doesn't increase cache" test SAVE doesn't increase cache 2460491776 Could not connect to Valkey at 127.0.0.1:8080: Connection refused ``` Added waits for server to start, locally run, it helps --------- Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
After #3103 time sensitive `test-ubuntu-reclaim-cache` started to fail because now startup always includes 30ms of calibration of HW clock, that's why we get this output: ``` Run echo "test SAVE doesn't increase cache" test SAVE doesn't increase cache 2460491776 Could not connect to Valkey at 127.0.0.1:8080: Connection refused ``` Added waits for server to start, locally run, it helps --------- Signed-off-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
After #3103 time sensitive
test-ubuntu-reclaim-cachestarted to fail because now startup always includes 30ms of calibration of HW clock, that's why we get this output:Added waits for server to start, locally run, it helps