Fix unnecessary recompilation in gtest Makefile#3063
Merged
madolson merged 1 commit intovalkey-io:feature-gtestfrom Jan 15, 2026
Merged
Fix unnecessary recompilation in gtest Makefile#3063madolson merged 1 commit intovalkey-io:feature-gtestfrom
madolson merged 1 commit intovalkey-io:feature-gtestfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature-gtest #3063 +/- ##
=================================================
- Coverage 74.33% 74.19% -0.14%
=================================================
Files 129 129
Lines 70974 70974
=================================================
- Hits 52756 52658 -98
- Misses 18218 18316 +98 🚀 New features to boost your workflow:
|
Signed-off-by: Harry Lin <harrylhl@amazon.com>
JimB123
approved these changes
Jan 15, 2026
Member
JimB123
left a comment
There was a problem hiding this comment.
Looks ok. Not sure about some of the makefile intricacies, but given that this is for test build, risk is low. Further refinements are easy to make.
I expect additional changes/refinements as this is being prepared in the "feature-gtest" branch.
harrylin98
added a commit
to harrylin98/valkey_forked
that referenced
this pull request
Feb 19, 2026
This PR fixes the issue where changes to src files did not trigger a rebuild of libvalkey.a when rerunning `make test-gtest`. It also resolves the problem where unchanged .cpp test files were unnecessarily recompiled during make test-gtest. Now: If nothing changed: - Nothing rebuilds, no relinking occurs. If only C++ test files changed: - Both libvalkey.a and C++ test files recompile (because release.o changes) - Test executable relinks If only src code changed: - Only libvalkey.a rebuilds - C++ test files do not recompile - Test executable relinks If both changed: - Both libvalkey.a and C++ test files rebuild - Test executable relinks Signed-off-by: Harry Lin <harrylhl@amazon.com> Co-authored-by: Harry Lin <harrylhl@amazon.com> Signed-off-by: Harry Lin <49881386+harrylin98@users.noreply.github.com>
harrylin98
added a commit
to harrylin98/valkey_forked
that referenced
this pull request
Feb 20, 2026
This PR fixes the issue where changes to src files did not trigger a rebuild of libvalkey.a when rerunning `make test-gtest`. It also resolves the problem where unchanged .cpp test files were unnecessarily recompiled during make test-gtest. Now: If nothing changed: - Nothing rebuilds, no relinking occurs. If only C++ test files changed: - Both libvalkey.a and C++ test files recompile (because release.o changes) - Test executable relinks If only src code changed: - Only libvalkey.a rebuilds - C++ test files do not recompile - Test executable relinks If both changed: - Both libvalkey.a and C++ test files rebuild - Test executable relinks Signed-off-by: Harry Lin <harrylhl@amazon.com> Co-authored-by: Harry Lin <harrylhl@amazon.com> Signed-off-by: Harry Lin <49881386+harrylin98@users.noreply.github.com>
harrylin98
added a commit
to harrylin98/valkey_forked
that referenced
this pull request
Feb 20, 2026
This PR fixes the issue where changes to src files did not trigger a rebuild of libvalkey.a when rerunning `make test-gtest`. It also resolves the problem where unchanged .cpp test files were unnecessarily recompiled during make test-gtest. Now: If nothing changed: - Nothing rebuilds, no relinking occurs. If only C++ test files changed: - Both libvalkey.a and C++ test files recompile (because release.o changes) - Test executable relinks If only src code changed: - Only libvalkey.a rebuilds - C++ test files do not recompile - Test executable relinks If both changed: - Both libvalkey.a and C++ test files rebuild - Test executable relinks Signed-off-by: Harry Lin <harrylhl@amazon.com> Co-authored-by: Harry Lin <harrylhl@amazon.com> Signed-off-by: Harry Lin <49881386+harrylin98@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where changes to src files did not trigger a rebuild of
libvalkey.a when rerunning
make test-gtest.It also resolves the problem where unchanged .cpp test files were unnecessarily recompiled
during make test-gtest.
Now:
If nothing changed:
If only C++ test files changed:
If only src code changed:
If both changed: