[Test Fix] flaky benchmark test for warmup

[roshkhatri]

Fixes: #2859
Increased the warmup to 2 sec so we can verify that it runs more number of commands than the actual benchmark.

Ran it 100 times here for the same setup, and doesn't seem to fail here: https://github.com/roshkhatri/valkey/actions/runs/19844200320/job/56858357619

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.42%. Comparing base (4a0e20b) to head (5b55ff3).
⚠️ Report is 5 commits behind head on unstable.

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable    #2890      +/-   ##
============================================
- Coverage     72.44%   72.42%   -0.02%     
============================================
  Files           128      128              
  Lines         70487    70487              
============================================
- Hits          51066    51052      -14     
- Misses        19421    19435      +14     

see 13 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[zuiderkwast]

LGTM, but I don't really understand why this fails in the first place.

How can --warmup 1 run for one seconds and not run any command? Can the server be that slow?

We run --warmup 1 -n 50 and we assert that we run > 50 commands, which means > 0 commands during warmup.

[sarthakaggarwal97]

LGTM as it deflakes the test. Thanks @roshkhatri for the change. This failed again yesterday, which otherwise would have been a green run :D

I do agree with @zuiderkwast that the reasoning behind this solution is unclear.

[roshkhatri]

The one that failed yesterday seems to be another test: *** [TIMEOUT]: benchmark: warmup and duration are cumulative in tests/integration/valkey-benchmark.tcl

About the reasoning, I think sometime for some hosts it gets too slow that it does not start generating traffic in 1 sec.

[sarthakaggarwal97]

Oh, you are right. Let me open an issue for this.