Remove the unused value duplicate API from dict of libvalkey#2387
Merged
zuiderkwast merged 1 commit intovalkey-io:unstablefrom Aug 5, 2025
Merged
Remove the unused value duplicate API from dict of libvalkey#2387zuiderkwast merged 1 commit intovalkey-io:unstablefrom
zuiderkwast merged 1 commit intovalkey-io:unstablefrom
Conversation
Signed-off-by: Xiaolong Chen <fukua95@gmail.com>
cxljs
changed the title
dictSetVal of dict consistent with the other three
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #2387 +/- ##
============================================
+ Coverage 71.44% 71.51% +0.06%
============================================
Files 123 123
Lines 67177 67177
============================================
+ Hits 47992 48039 +47
+ Misses 19185 19138 -47 🚀 New features to boost your workflow:
|
Contributor
Contributor
Member
Author
|
Got it! I'll create a similar PR for libvalkey soon. |
zuiderkwast
approved these changes
Aug 5, 2025
allenss-amazon
pushed a commit
to allenss-amazon/valkey-core
that referenced
this pull request
Aug 19, 2025
…io#2387) The commit (valkey-io@0700c44) removes the unused value duplicate API from dict, and libvalkey's dict needs to remain consistent with it. Signed-off-by: Xiaolong Chen <fukua95@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit (0700c44) removes the unused value duplicate API from dict, and libvalkey's dict needs to remain consistent with it.