Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename redis in valkey-cli file comments and prints. #222

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

Shivshankar-Reddy
Copy link
Contributor

@Shivshankar-Reddy Shivshankar-Reddy commented Apr 5, 2024

Updated to Valkey in valkey-cli.c file's comments and prints.

  • The output of valkey-cli --help
  • The output of the cli built-in HELP command
  • The prompt in interactive valkey-cli -s unixsocket
  • The history file and the default rc file (changed filename)

Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I think we shall also backport some of this (the prompt in the interactive cli program) to our release 7.2.x. @valkey-io/core-team

src/valkey-cli.c Outdated Show resolved Hide resolved
src/valkey-cli.c Outdated Show resolved Hide resolved
src/valkey-cli.c Outdated Show resolved Hide resolved
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Another pr for the macros sounds good.

@zuiderkwast zuiderkwast merged commit 05d1657 into valkey-io:unstable Apr 10, 2024
14 checks passed
zuiderkwast pushed a commit that referenced this pull request Apr 10, 2024
Updated to Valkey in valkey-cli.c file's comments and prints.

* The output of valkey-cli --help
* The output of the cli built-in HELP command
* The prompt in interactive valkey-cli -s unixsocket
* The history file and the default rc file (changed filename)

---------

Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
@zuiderkwast
Copy link
Contributor

@valkey-io/core-team I have cherry-picked this to the 7.2 branch. (I did it after the rc1 release, so it will be in the next one.)

@zuiderkwast zuiderkwast added the rebranding Valkey is not Redis label Apr 10, 2024
@Shivshankar-Reddy Shivshankar-Reddy deleted the cli-c-file-rename branch April 18, 2024 16:57
PatrickJS pushed a commit to PatrickJS/placeholderkv that referenced this pull request Apr 24, 2024
Updated to Valkey in valkey-cli.c file's comments and prints.

* The output of valkey-cli --help
* The output of the cli built-in HELP command
* The prompt in interactive valkey-cli -s unixsocket
* The history file and the default rc file (changed filename)

---------

Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rebranding Valkey is not Redis
Projects
Status: Backported
Development

Successfully merging this pull request may close these issues.

3 participants