-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename redis in valkey-cli file comments and prints. #222
Rename redis in valkey-cli file comments and prints. #222
Conversation
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
45bc2bd
to
27930d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I think we shall also backport some of this (the prompt in the interactive cli program) to our release 7.2.x. @valkey-io/core-team
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Another pr for the macros sounds good.
Updated to Valkey in valkey-cli.c file's comments and prints. * The output of valkey-cli --help * The output of the cli built-in HELP command * The prompt in interactive valkey-cli -s unixsocket * The history file and the default rc file (changed filename) --------- Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
@valkey-io/core-team I have cherry-picked this to the 7.2 branch. (I did it after the rc1 release, so it will be in the next one.) |
Updated to Valkey in valkey-cli.c file's comments and prints. * The output of valkey-cli --help * The output of the cli built-in HELP command * The prompt in interactive valkey-cli -s unixsocket * The history file and the default rc file (changed filename) --------- Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Updated to Valkey in valkey-cli.c file's comments and prints.