Run external cluster tests with multiple databases#2176
Merged
zuiderkwast merged 5 commits intovalkey-io:unstablefrom Jun 11, 2025
Merged
Run external cluster tests with multiple databases#2176zuiderkwast merged 5 commits intovalkey-io:unstablefrom
zuiderkwast merged 5 commits intovalkey-io:unstablefrom
Conversation
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Change runtest flag --cluster-mode to no longer imply --single-db. This allows more tests to run against an external node running in cluster mode. Also fix incorrectly tagged tests so that ./runtest --singledb passes. Without this change, it doesn't, becuase several tests are incorrectly tagged as external:skip instead of singledb:skip or cluster:skip. Apparently, we only run with --singledb in the CI when we run against an external node, so this was not detected. The tags are used like this: * singledb:skip is used for tests that do select and assume that a client has selected db 9. * cluster:skip is used when the test uses SWAPDB, cross-slot commands other things forbidden in cluster mode. Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #2176 +/- ##
============================================
- Coverage 71.50% 71.37% -0.14%
============================================
Files 122 122
Lines 66452 66452
============================================
- Hits 47515 47428 -87
- Misses 18937 19024 +87 🚀 New features to boost your workflow:
|
madolson
reviewed
Jun 10, 2025
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
madolson
approved these changes
Jun 10, 2025
enjoy-binbin
approved these changes
Jun 11, 2025
chzhoo
pushed a commit
to chzhoo/valkey
that referenced
this pull request
Jun 12, 2025
Change the runtest flag `--cluster-mode` to no longer imply `--single-db`. This allows more tests to run against an external node running in cluster mode. Also fix incorrectly tagged tests so that `./runtest --singledb` passes locally. Without this change, this doesn't pass because several tests are incorrectly tagged as external:skip instead of singledb:skip or cluster:skip. In the CI, we apparently only run with singledb when implied by `--cluster-mode` (until now), which we only use in the external cluster mode test. That's why the incorrect tags were not detected. * singledb:skip is used for tests that do select and assume that a client has selected db 9. * cluster:skip is used when the test uses SWAPDB, cross-slot commands other things forbidden in cluster mode. Additional fix: End tests with a linebreak when running with the `--fastfail` flag. A program that doesn't end its output with a linebreak annoys the prompt in the terminal. --------- Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech> Signed-off-by: chzhoo <czawyx@163.com>
shanwan1
pushed a commit
to shanwan1/valkey
that referenced
this pull request
Jun 13, 2025
Change the runtest flag `--cluster-mode` to no longer imply `--single-db`. This allows more tests to run against an external node running in cluster mode. Also fix incorrectly tagged tests so that `./runtest --singledb` passes locally. Without this change, this doesn't pass because several tests are incorrectly tagged as external:skip instead of singledb:skip or cluster:skip. In the CI, we apparently only run with singledb when implied by `--cluster-mode` (until now), which we only use in the external cluster mode test. That's why the incorrect tags were not detected. * singledb:skip is used for tests that do select and assume that a client has selected db 9. * cluster:skip is used when the test uses SWAPDB, cross-slot commands other things forbidden in cluster mode. Additional fix: End tests with a linebreak when running with the `--fastfail` flag. A program that doesn't end its output with a linebreak annoys the prompt in the terminal. --------- Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech> Signed-off-by: shanwan1 <shanwan1@intel.com>
ranshid
pushed a commit
to ranshid/valkey
that referenced
this pull request
Jun 18, 2025
Change the runtest flag `--cluster-mode` to no longer imply `--single-db`. This allows more tests to run against an external node running in cluster mode. Also fix incorrectly tagged tests so that `./runtest --singledb` passes locally. Without this change, this doesn't pass because several tests are incorrectly tagged as external:skip instead of singledb:skip or cluster:skip. In the CI, we apparently only run with singledb when implied by `--cluster-mode` (until now), which we only use in the external cluster mode test. That's why the incorrect tags were not detected. * singledb:skip is used for tests that do select and assume that a client has selected db 9. * cluster:skip is used when the test uses SWAPDB, cross-slot commands other things forbidden in cluster mode. Additional fix: End tests with a linebreak when running with the `--fastfail` flag. A program that doesn't end its output with a linebreak annoys the prompt in the terminal. --------- Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the runtest flag
--cluster-modeto no longer imply--single-db. This allows more tests to run against an external node running in cluster mode.Also fix incorrectly tagged tests so that
./runtest --singledbpasses locally.Without this change, this doesn't pass because several tests are incorrectly tagged as external:skip instead of singledb:skip or cluster:skip. In the CI, we apparently only run with singledb when implied by
--cluster-mode(until now), which we only use in the external cluster mode test. That's why the incorrect tags were not detected.Additional fix: End tests with a linebreak when running with the
--fastfailflag. A program that doesn't end its output with a linebreak annoys the prompt in the terminal.