Use _Thread_local to solve threads.h build issue #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently this will fail to compile in some masOS version. Fixes valkey-io#1051. Signed-off-by: Binbin <binloveplay1314@qq.com>
enjoy-binbin
force-pushed
the
thread_local
branch
from
7ee63d6 to
2045db3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1053 +/- ##
============================================
+ Coverage 70.62% 70.63% +0.01%
============================================
Files 114 114
Lines 61672 61672
============================================
+ Hits 43555 43565 +10
+ Misses 18117 18107 -10
|
madolson
approved these changes
Sep 19, 2024
enjoy-binbin
added
the
release-notes
madolson
pushed a commit
to madolson/valkey
that referenced
this pull request
Sep 30, 2024
Apparently this will fail to compile in some masOS version. And internet claims _Thread_local is portable. Fixes valkey-io#1051. Signed-off-by: Binbin <binloveplay1314@qq.com>
PingXie
pushed a commit
to PingXie/valkey
that referenced
this pull request
Oct 9, 2024
Apparently this will fail to compile in some masOS version. And internet claims _Thread_local is portable. Fixes valkey-io#1051. Signed-off-by: Binbin <binloveplay1314@qq.com>
naglera
pushed a commit
to naglera/placeholderkv
that referenced
this pull request
Oct 10, 2024
Apparently this will fail to compile in some masOS version. And internet claims _Thread_local is portable. Fixes valkey-io#1051. Signed-off-by: Binbin <binloveplay1314@qq.com> Signed-off-by: naglera <anagler123@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently this will fail to compile in some masOS version.
And internet claims _Thread_local is portable.
Fixes #1051.