[BUG] cluster-annouce-ip accepts not only IP

[esebole]

Hi,
recently I was working on migration from RADIX to Valkey-go. I made a small mistake in the code which I was unaware of, but it got me a real headache. It seams that cluster-annouce-ip accepts not only IP. I think the input for that should be validated. In my code by mistake I used a string which was IP:PORT.

Here is a code example:

cmd := client.B().ConfigSet().ParameterValue().ParameterValue("cluster-announce-ip", ipAddr).Build()

where ipAddr is 10.1.131.239:6380. When you will execute the command the CLUSTER INFO looks like that

036e48d5a1c9c6af6c3bce08aa0604a5e720a37e 10.1.131.239:6380:6380@16380 myself,master - 0 0 0 connected

There is a port doubled and GOSSIP is not working properly.

Expected behavior

I would expect to have an error in such case and not accept a string which is not IP.

[esebole]

After exeprimenting with with it a bit more I would say that there is no I validation at all:
cmd := client.B().ConfigSet().ParameterValue().ParameterValue("cluster-announce-ip", "NotIPv4NorIPv6").Build()
and cluster info after executing it.
3498c323e5b6bcbc012092f4cf0eec64054baa0c NotIPv4NorIPv6:6380@16380 myself,master - 0 0 0 connected

[zuiderkwast]

Hi Sebastian,

I notices a few years ago and opened a PR for this back in the redis era, here: redis/redis#12583