Skip to content

Conversation

@adam-fowler
Copy link
Collaborator

As we require NIOTSEventLoop to conform to NIOSerialEventLoopExecutor

As we require NIOTSEventLoop to conform to NIOSerialEventLoopExecutor

Signed-off-by: Adam Fowler <adamfowler71@gmail.com>
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

✅ Pull request no significant performance differences ✅

Summary

New baseline 'pull_request' is WITHIN the 'main' baseline thresholds.

Full Benchmark Comparison

Comparing results between 'main' and 'pull_request'

Host '2d3922934434' with 4 'x86_64' processors with 15 GB memory, running:
#18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025

ValkeyBenchmarks

Client: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 75 77 77 78 82 82 82 8
pull_request 74 77 77 79 83 83 83 8
Δ -1 0 0 1 1 1 1 0
Improvement % 1 0 0 -1 -1 -1 -1 0

Client: GET benchmark | parallel 20 | 20 concurrent connections metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 70 76 79 82 86 88 88 26
pull_request 74 77 80 82 84 84 84 32
Δ 4 1 1 0 -2 -4 -4 6
Improvement % -6 -1 -1 0 2 5 5 6

Connection: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 4 4 4 4 4 15 15 10
pull_request 4 4 4 4 15 15 15 11
Δ 0 0 0 0 11 0 0 1
Improvement % 0 0 0 0 -275 0 0 1

Connection: GET benchmark – NoOpTracer metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 7 8 8 10 11 11 11 10
pull_request 7 8 8 10 11 11 11 10
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

Connection: Pipeline array benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 32 33 34 34 34 34 34 7
pull_request 33 33 34 34 34 34 34 7
Δ 1 0 0 0 0 0 0 0
Improvement % -3 0 0 0 0 0 0 0

Connection: Pipeline benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 33 33 33 34 34 34 34 7
pull_request 33 33 33 34 34 34 34 7
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

HashSlot – {user}.whatever metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 22
pull_request 0 0 0 0 0 0 0 22
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

ValkeyCommandEncoder – Command with 7 words metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 905
pull_request 0 0 0 0 0 0 0 903
Δ 0 0 0 0 0 0 0 -2
Improvement % 0 0 0 0 0 0 0 -2

ValkeyCommandEncoder – Simple GET metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 2428
pull_request 0 0 0 0 0 0 0 2431
Δ 0 0 0 0 0 0 0 3
Improvement % 0 0 0 0 0 0 0 3

ValkeyCommandEncoder – Simple MGET 15 keys metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 458
pull_request 0 0 0 0 0 0 0 458
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

@adam-fowler adam-fowler merged commit f748b9f into main Dec 2, 2025
15 checks passed
@adam-fowler adam-fowler deleted the nio-transport-version branch December 2, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants