updates text in changes file and pr template #33
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahmedsobeh <ahmed.sobeh@aiven.io> Signed-off-by: Jay Miller <kjaymiller@gmail.com>
Signed-off-by: ahmedsobeh <ahmed.sobeh@aiven.io> Signed-off-by: Jay Miller <kjaymiller@gmail.com>
Signed-off-by: Jay Miller <kjaymiller@gmail.com>
kjaymiller
force-pushed
the
jm-updates-changes
branch
from
e5083b9 to
c5c194c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
=======================================
Coverage ? 75.02%
=======================================
Files ? 132
Lines ? 34350
Branches ? 0
=======================================
Hits ? 25772
Misses ? 8578
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
Hi Jay! Can you rebase this PR so that it only contains your commit? Thanks |
This was referenced Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Resolves #31 by removing the changes update request in the PR template and adding a comment to the top of the
CHANGESfile.