change destination_db's type constraint in copy() method ?

[spyinx]

when i read code in copy() method, i found destination_db can be int type and works well, but the type constraint hints it can only be str or None：

>>> from valkey import Valkey
>>> r = Valkey(host="127.0.0.1", port=6888, password='xxxxx')
>>> r.copy("hello", "abc", 1, True)
True
>>> r.copy("hello", "abc", "1", True)
True

valkey-py/valkey/commands/core.py

Lines 1661 to 1667 in c490780

	def copy(
	self,
	source: str,
	destination: str,
	destination_db: Union[str, None] = None,
	replace: bool = False,
	) -> ResponseT:

so, i think this can be changed like this：

destination_db: Optional[Union[int, str]] = None,
or 
destination_db: Union[int, str, None] = None,

[aiven-sal]

Hi! Thank you for reporting. Your proposal sounds correct to me. Would you like to create a PR for this?

[spyinx]

Hi! Thank you for reporting. Your proposal sounds correct to me. Would you like to create a PR for this?

i will create a pr to fix this issue, thanks for your reply

[spyinx]

@aiven-sal move() method have the same problem, the db param constraint to int, but str also works fine：

>>> r.move("hello", "3")
True

[amirreza8002]

hi
there are a lot of problems with the type hints of this package, since it inherits from redis-py
me and some other people are thinking of fixing some parts, you can join if you like.

see #134 for more

[spyinx]

hi there are a lot of problems with the type hints of this package, since it inherits from redis-py me and some other people are thinking of fixing some parts, you can join if you like.

see #134 for more

ok, since you are working on it, i will not focus on this, i just read the code and see the problem. thanks for your work. Now i'm not familiar with the code and need time to learn more. if i have the ability, then i can join the community to fix bugs.

[aiven-sal]

hi there are a lot of problems with the type hints of this package, since it inherits from redis-py me and some other people are thinking of fixing some parts, you can join if you like.
see #134 for more

ok, since you are working on it, i will not focus on this, i just read the code and see the problem. thanks for your work. Now i'm not familiar with the code and need time to learn more. if i have the ability, then i can join the community to fix bugs.

Hi! This contribution is welcome. You don't have to join the work in #134, unless you want to do it. #134 is a valiant effort from the community to fix typing, but it will take a lot of time. In the mean time we will merge small PRs that fix obvious typing issues.

[spyinx]

Thank you all for taking care of the newcomers. I am still working hard on the code and hope to have the opportunity to fix bugs for the community in the future