fixed e2e tests failing intermittently & review comments from past PR #54
Merged
sandeepkunusoth merged 5 commits intovalkey-io:mainfrom Jan 15, 2026
Merged
Conversation
Signed-off-by: Sandeep Kunusoth <sandeepkunsoth000@gmail.com>
…aded state Signed-off-by: Sandeep Kunusoth <sandeepkunsoth000@gmail.com>
Signed-off-by: Sandeep Kunusoth <sandeepkunsoth000@gmail.com>
Signed-off-by: Sandeep Kunusoth <sandeepkunsoth000@gmail.com>
bjosv
reviewed
Jan 15, 2026
Collaborator
bjosv
left a comment
bjosv
left a comment
There was a problem hiding this comment.
We probably need to remove the expectation of a NodeAdded event as well.
When I remove that I can run 30 times locally without any issues.
Signed-off-by: Sandeep Kunusoth <sandeepkunsoth000@gmail.com>
bjosv
approved these changes
Jan 15, 2026
Collaborator
bjosv
left a comment
bjosv
left a comment
There was a problem hiding this comment.
Great! This will make the tests more stable until fixing found issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes e2e test failing due to #43 temporarily by deleting replica deployment in e2e tests instead of deleting random deployment (either replica or shard previously). We need to add back e2e test to delete shard and allow it to recover once above issue is fixed.
Also addressed review comments from metrics exporter PR @bjosv #49