Io threads blog #102
Merged
Io threads blog #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Touitou <83634223+touitou-dan@users.noreply.github.com>
1 task
madolson
reviewed
Jul 14, 2024
content/blog/2024-07-07-aws-to-contribute-efficiency-improvements-for-ValKey-8.md
Outdated
Show resolved
Hide resolved
content/blog/2024-07-07-aws-to-contribute-efficiency-improvements-for-ValKey-8.md
Outdated
Show resolved
Hide resolved
content/blog/2024-07-07-aws-to-contribute-efficiency-improvements-for-ValKey-8.md
Outdated
Show resolved
Hide resolved
content/blog/2024-07-07-aws-to-contribute-efficiency-improvements-for-ValKey-8.md
Outdated
Show resolved
Hide resolved
content/blog/2024-07-07-aws-to-contribute-efficiency-improvements-for-ValKey-8.md
Outdated
Show resolved
Hide resolved
content/blog/2024-07-07-aws-to-contribute-efficiency-improvements-for-ValKey-8.md
Outdated
Show resolved
Hide resolved
content/blog/2024-07-07-aws-to-contribute-efficiency-improvements-for-ValKey-8.md
Show resolved
Hide resolved
content/blog/2024-07-07-aws-to-contribute-efficiency-improvements-for-ValKey-8.md
Outdated
Show resolved
Hide resolved
content/blog/2024-07-07-aws-to-contribute-efficiency-improvements-for-ValKey-8.md
Outdated
Show resolved
Hide resolved
content/blog/2024-07-07-aws-to-contribute-efficiency-improvements-for-ValKey-8.md
Outdated
Show resolved
Hide resolved
avocadosand
reviewed
Jul 15, 2024
There was a problem hiding this comment.
It's getting there! Main feedback is to identify a call to action, to tell the reader up front what you are going to tell them in detail below, and to summarize what they learned at the bottom. Keep in mind the POV - totally fine that its AWS POV - we want the reader to be able to disambiguate between the two though.
content/blog/2024-07-07-aws-to-contribute-efficiency-improvements-for-ValKey-8.md
Show resolved
Hide resolved
content/blog/2024-07-07-aws-to-contribute-efficiency-improvements-for-ValKey-8.md
Outdated
Show resolved
Hide resolved
content/blog/2024-07-07-aws-to-contribute-efficiency-improvements-for-ValKey-8.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Uri Yagelnik <uriy@amazon.com>
madolson
reviewed
Jul 17, 2024
content/blog/2024-07-07-aws-to-contribute-efficiency-improvements-for-ValKey-8.md
Outdated
Show resolved
Hide resolved
content/blog/2024-07-07-aws-to-contribute-efficiency-improvements-for-ValKey-8.md
Outdated
Show resolved
Hide resolved
content/blog/2024-07-07-aws-to-contribute-efficiency-improvements-for-ValKey-8.md
Outdated
Show resolved
Hide resolved
…nts-for-ValKey-8.md Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: uriyage <78144248+uriyage@users.noreply.github.com>
…nts-for-ValKey-8.md Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: uriyage <78144248+uriyage@users.noreply.github.com>
Signed-off-by: Uri Yagelnik <uriy@amazon.com>
madolson
approved these changes
Jul 19, 2024
content/blog/2024-07-07-aws-to-contribute-efficiency-improvements-for-ValKey-8.md
Outdated
Show resolved
Hide resolved
…nts-for-ValKey-8.md Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: uriyage <78144248+uriyage@users.noreply.github.com>
Signed-off-by: Uri Yagelnik <uriy@amazon.com>
madolson
approved these changes
Jul 31, 2024
madolson
added a commit
that referenced
this pull request
Aug 5, 2024
### Description Addressed PR comments for I/O threads blog post. Previous PR: #98 ### Issues Resolved - ### Check List - [ V] Commits are signed per the DCO using `--signoff` By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License. --------- Signed-off-by: Dan Touitou <83634223+touitou-dan@users.noreply.github.com> Signed-off-by: Uri Yagelnik <uriy@amazon.com> Co-authored-by: Dan Touitou <83634223+touitou-dan@users.noreply.github.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressed PR comments for I/O threads blog post.
Previous PR: #98
Issues Resolved
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.