Python: adds ZPOPMAX command #996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shohamazon
force-pushed
the
python/zpopmax
branch
from
c5d903b to
30ee76f
Compare
barshaul
reviewed
Feb 20, 2024
| async def test_zpopmax(self, redis_client: TRedisClient): | ||
| key = get_random_string(10) | ||
| members_scores = {"a": 1.0, "b": 2.0, "c": 3.0} | ||
| assert await redis_client.zadd(key, members_scores=members_scores) == 3 |
There was a problem hiding this comment.
minor- why are you passing the name of the argument, members_scores=members_scores?
barshaul
reviewed
Feb 20, 2024
| members_scores = {"a": 1.0, "b": 2.0, "c": 3.0} | ||
| assert await redis_client.zadd(key, members_scores=members_scores) == 3 | ||
| assert await redis_client.zpopmax(key) == {"c": 3.0} | ||
|
|
barshaul
approved these changes
Feb 20, 2024
shohamazon
force-pushed
the
python/zpopmax
branch
from
30ee76f to
9f88359
Compare
| @@ -107,6 +107,7 @@ enum RequestType { | |||
| HLen = 69; | |||
| Echo = 70; | |||
| ZPopMin = 71; | |||
| ZPopMax=72; | |||
There was a problem hiding this comment.
Suggested change
| ZPopMax=72; | |
| ZPopMax = 72; |
There was a problem hiding this comment.
nit: add a linter for protobuf files
shohamazon
force-pushed
the
python/zpopmax
branch
from
9f88359 to
aec77a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.