adds RPOPCount and LPOPCount to transaction #874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please add to tests |
shohamazon
force-pushed
the
list_commands_transaction
branch
2 times, most recently
from
000d6ae to
c587142
Compare
Done |
shachlanAmazon
approved these changes
Feb 1, 2024
| @@ -644,7 +644,7 @@ export class BaseClient { | |||
| * If `key` holds a value that is not a list, an error is raised. | |||
| */ | |||
| public lpop( | |||
| key: string, | |||
There was a problem hiding this comment.
please either remove stylistic changes, or update the eslint rules to enforce this.
On my machine this is changed to a single line 🤷
shohamazon
force-pushed
the
list_commands_transaction
branch
3 times, most recently
from
45984e4 to
d4782c4
Compare
shohamazon
force-pushed
the
list_commands_transaction
branch
from
d4782c4 to
31b93be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.