Skip to content

Fix flaky test: test pubsub shardchannels_true #4925 #4997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix flaky test: test pubsub shardchannels_true #4925 #4997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 26 additions & 8 deletions node/tests/PubSub.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3811,15 +3811,33 @@ describe("PubSub", () => {
pubSub,
);

// Test pubsubShardchannels without pattern
const channels = await (
client2 as GlideClusterClient
).pubsubShardChannels();
expect(new Set(channels)).toEqual(
new Set([channel1, channel2, channel3]),
);
{
// Wait up to 3 seconds (60 * 50ms)
for (let i = 0; i < 60; i++) {
try {
const channels = await (
client2 as GlideClusterClient
).pubsubShardChannels();

if (channels.length === 3) {
break;
}
} catch {
// Ignore
}

await new Promise((r) => setTimeout(r, 50));
}

const channels = await (
client2 as GlideClusterClient
).pubsubShardChannels();

expect(new Set(channels)).toEqual(
new Set([channel1, channel2, channel3]),
);
}

// Test pubsubShardchannels with pattern
const channelsWithPattern = await (
client2 as GlideClusterClient
).pubsubShardChannels({ pattern });
Expand Down
Loading