Fix flaky test: test pubsub channels and shardchannels separation #4927 #4996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the flaky test
test pubsub channels and shardchannels separation_truetracked in #4927.The failure is caused by the eventual consistency model of the Redis Cluster Gossip protocol. When a client subscribes to a channel on one node, it takes a small amount of time for this metadata to propagate to other nodes. The test was asserting the existence of the channel immediately after subscription, leading to intermittent failures when the target node hadn't received the update yet.
Changes
pubsubChannelscheck (up to a timeout) until the expected channel appears, ensuring the cluster metadata is synchronized.Verification
Related Issue
Fixes #4927