Windows Java CI - Github-hosted, WSL

.gitattributes

@@ -0,0 +1,7 @@
+# Ensure shell scripts and Python files always use Unix line endings (LF)
+*.sh text eol=lf
+*.py text eol=lf
+
+# Ensure these specific files use Unix line endings
+utils/cluster_manager.py text eol=lf
+utils/*.sh text eol=lf

.github/ISSUE_TEMPLATE/feature-request.yml

@@ -1,5 +1,5 @@
 ---
-name: 🚀 Feature Request
+name: Feature Request
 description: Suggest an idea for this project
 title: "(topic): (short issue description)"
 labels: [feature-request, needs-triage]

.github/json_matrices/build-matrix.json

@@ -81,5 +81,27 @@
         "IMAGE": "amazonlinux:latest",
         "PACKAGE_MANAGERS": [],
         "languages": ["python", "node", "java", "go"]
+    },
+    {
+        "OS": "windows",
+        "NAMED_OS": "windows",
+        "RUNNER": "windows-latest",
+        "ARCH": "x64",
+        "TARGET": "x86_64-pc-windows-msvc",
+        "PACKAGE_MANAGERS": ["maven"],
+        "languages": ["java"],
+        "run": "always",
+        "comment": "GitHub-hosted Windows runner with WSL for local Valkey testing"
+    },
+    {
+        "OS": "windows",
+        "NAMED_OS": "windows",
+        "RUNNER": "windows-latest-arm64",
+        "ARCH": "arm64",
+        "TARGET": "aarch64-pc-windows-msvc",
+        "PACKAGE_MANAGERS": ["maven"],
+        "languages": ["java"],
+        "run": "always",
+        "comment": "GitHub-hosted Windows ARM64 runner with WSL for local Valkey testing"
     }
 ]

.github/workflows/codeql.yml

@@ -85,12 +85,21 @@ jobs:
             - name: Install protoc compiler
               if: matrix.language == 'go'
               shell: bash
+              env:
+                  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
               run: |
                   # Check if protoc is already installed with correct version
                   if ! command -v protoc &> /dev/null || ! protoc --version | grep -q "29.1"; then
                       echo "Installing protoc 29.1..."
                       PB_REL="https://github.com/protocolbuffers/protobuf/releases"
-                      curl -LO $PB_REL/download/v29.1/protoc-29.1-linux-x86_64.zip
+
+                      # Add authentication header if token is available
+                      if [ -n "$GITHUB_TOKEN" ]; then
+                          curl -H "Authorization: Bearer $GITHUB_TOKEN" -LO $PB_REL/download/v29.1/protoc-29.1-linux-x86_64.zip
+                      else
+                          curl -LO $PB_REL/download/v29.1/protoc-29.1-linux-x86_64.zip
+                      fi
+
                       sudo unzip protoc-29.1-linux-x86_64.zip -d /usr/local
                       sudo chmod +x /usr/local/bin/protoc
                   else
@@ -125,12 +134,21 @@ jobs:
             - name: Build Java/Kotlin components
               if: matrix.language == 'java-kotlin'
               shell: bash
+              env:
+                  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
               run: |
                   # Check if protoc is already installed with correct version
                   if ! command -v protoc &> /dev/null || ! protoc --version | grep -q "29.1"; then
                       echo "Installing protoc 29.1..."
                       PB_REL="https://github.com/protocolbuffers/protobuf/releases"
-                      curl -LO $PB_REL/download/v29.1/protoc-29.1-linux-x86_64.zip
+
+                      # Add authentication header if token is available
+                      if [ -n "$GITHUB_TOKEN" ]; then
+                          curl -H "Authorization: Bearer $GITHUB_TOKEN" -LO $PB_REL/download/v29.1/protoc-29.1-linux-x86_64.zip
+                      else
+                          curl -LO $PB_REL/download/v29.1/protoc-29.1-linux-x86_64.zip
+                      fi
+
                       sudo unzip protoc-29.1-linux-x86_64.zip -d /usr/local
                       sudo chmod +x /usr/local/bin/protoc
                   else

.github/workflows/create-test-matrices/action.yml

@@ -20,6 +20,10 @@ inputs:
             - use-self-hosted
             - use-github
         default: false
+    run-with-windows-self-hosted:
+        description: "Include self-hosted Windows runners"
+        type: boolean
+        default: false
     containers:
         description: "Run in containers"
         required: true
@@ -46,12 +50,14 @@ runs:
               EVENT_NAME: ${{ github.event_name }}
               RUN_FULL_MATRIX: ${{ inputs.run-full-matrix }}
               RUN_WITH_MACOS: ${{ inputs.run-with-macos }}
+              RUN_WITH_WINDOWS_SELF_HOSTED: ${{ inputs.run-with-windows-self-hosted }}
               CONTAINERS: ${{ inputs.containers }}
               LANGUAGE_NAME: ${{ inputs.language-name }}
           run: |
               echo "EVENT_NAME=$EVENT_NAME" >> $GITHUB_ENV
               echo "RUN_FULL_MATRIX=$RUN_FULL_MATRIX" >> $GITHUB_ENV
               echo "RUN_WITH_MACOS=$RUN_WITH_MACOS" >> $GITHUB_ENV
+              echo "RUN_WITH_WINDOWS_SELF_HOSTED=$RUN_WITH_WINDOWS_SELF_HOSTED" >> $GITHUB_ENV
               echo "CONTAINERS=$CONTAINERS" >> $GITHUB_ENV
               echo "LANGUAGE_NAME=$LANGUAGE_NAME" >> $GITHUB_ENV
 
@@ -63,12 +69,16 @@ runs:
               echo 'Select server engines to run tests against'
               if [[ "$EVENT_NAME" == "pull_request" || "$EVENT_NAME" == "push" || "$RUN_FULL_MATRIX" == "false" ]]; then
                   echo 'Pick engines marked as `"run": "always"` only - on PR, push or manually triggered job which does not require full matrix'
-                  jq -c '[.[] | select(.run == "always")]' < .github/json_matrices/engine-matrix.json | awk '{ printf "engine-matrix=%s\n", $0 }' | tee -a $GITHUB_OUTPUT
+                  ENGINES=$(jq -c '[.[] | select(.run == "always")]' < .github/json_matrices/engine-matrix.json)
               else
                   echo 'Pick all engines - on cron (schedule) or if manually triggered job requires a full matrix'
-                  jq -c . < .github/json_matrices/engine-matrix.json | awk '{ printf "engine-matrix=%s\n", $0 }' | tee -a $GITHUB_OUTPUT
+                  ENGINES=$(jq -c . < .github/json_matrices/engine-matrix.json)
               fi
 
+              # Note: Redis 6.2 exclusion for Windows is handled in the host matrix filtering
+              # rather than globally excluding it from all platforms
+              echo "engine-matrix=$ENGINES" >> $GITHUB_OUTPUT
+
         - name: Load host matrix
           id: load-host-matrix
           shell: bash
@@ -78,8 +88,8 @@ runs:
               echo 'Select runners (VMs) to run tests on'
 
               if [[ "$EVENT_NAME" == "pull_request" || "$EVENT_NAME" == "push" || "$RUN_FULL_MATRIX" == "false" ]]; then
-                echo 'Getting "always run" runners'
-                BASE_MATRIX=$(jq -c '[.[] | select(.run == "always")]' < .github/json_matrices/build-matrix.json)
+                echo 'Getting "always run" runners for this language'
+                BASE_MATRIX=$(jq --arg lang "$LANGUAGE_NAME" -c '[.[] | select(.run == "always" and .languages? and any(.languages[] == $lang; .) and '"$CONDITION"')]' < .github/json_matrices/build-matrix.json)
               else
                 echo 'Getting full matrix for language excluding macOS'
                 BASE_MATRIX=$(jq --arg lang "$LANGUAGE_NAME" -c '[.[] | select(.languages? and any(.languages[] == $lang; .) and '"$CONDITION"' and .TARGET != "aarch64-apple-darwin")]' < .github/json_matrices/build-matrix.json)
@@ -97,6 +107,17 @@ runs:
               else
                 FINAL_MATRIX="$BASE_MATRIX"
               fi
+
+              # Add Windows self-hosted runners if specified
+              if [[ "$RUN_WITH_WINDOWS_SELF_HOSTED" == "true" ]]; then
+                echo "Including self-hosted Windows runners"
+                WIN_RUNNERS=$(jq --arg lang "$LANGUAGE_NAME" -c '[.[] | select(.languages? and any(.languages[] == $lang; .) and '"$CONDITION"' and .TARGET == "x86_64-pc-windows-msvc" and (.RUNNER == ["self-hosted","windows","x64"]))]' < .github/json_matrices/build-matrix.json)
+                FINAL_MATRIX=$(echo "$FINAL_MATRIX" "$WIN_RUNNERS" | jq -sc 'add')
+              else
+                echo "Including GitHub-hosted Windows runners (WSL-enabled)"
+                WIN_RUNNERS=$(jq --arg lang "$LANGUAGE_NAME" -c '[.[] | select(.languages? and any(.languages[] == $lang; .) and '"$CONDITION"' and .TARGET == "x86_64-pc-windows-msvc" and .RUNNER == "windows-latest")]' < .github/json_matrices/build-matrix.json)
+                FINAL_MATRIX=$(echo "$FINAL_MATRIX" "$WIN_RUNNERS" | jq -sc 'add')
+              fi
 
               echo "host-matrix=$(echo $FINAL_MATRIX | tr -d '\n')" >> $GITHUB_OUTPUT
 

.github/workflows/dependabot-management.yml

@@ -250,7 +250,7 @@ jobs:
                       }
 
                       // Add basic changelog information
-                      const changelog = `## Changelog\n\nUpdated ${depName} from ${fromVersion} to ${toVersion}\n\n📋 To view detailed changes, visit the package repository or release notes.`;
+                      const changelog = `## Changelog\n\nUpdated ${depName} from ${fromVersion} to ${toVersion}\n\n[INFO] To view detailed changes, visit the package repository or release notes.`;
 
                       const newBody = `${body}\n\n${changelog}`;
 

.github/workflows/go.yml

@@ -152,8 +152,10 @@ jobs:
 
             - name: Install & build & test
               working-directory: go
+              shell: bash
               env:
                   RC_VERSION: ${{ github.event.inputs.rc-version }}
+                  CARGO_BUILD_JOBS: 1
               run: |
                   if [[ -n "$RC_VERSION" ]]; then
                     make install-tools
@@ -223,6 +225,8 @@ jobs:
 
             - name: Install and run linters
               working-directory: go
+              env:
+                  CARGO_BUILD_JOBS: 1
               run: |
                   make install-dev-tools install-build-tools gen-c-bindings generate-protobuf lint-ci
 
@@ -384,6 +388,7 @@ jobs:
 
             - name: Build and test
               working-directory: ./go
+              shell: bash
               env:
                   RC_VERSION: ${{ github.event.inputs.rc-version }}
               run: |
@@ -457,6 +462,7 @@ jobs:
 
             - name: Install & build & test
               working-directory: go
+              shell: bash
               env:
                   RC_VERSION: ${{ github.event.inputs.rc-version }}
               run: |

.github/workflows/install-rust-and-protoc/action.yml

@@ -1,32 +1,52 @@
-name: Install Rust tool chain and protoc
-
-inputs:
-    target:
-        description: "Specified target for rust toolchain, ex. x86_64-apple-darwin"
-        type: string
-        required: false
-        default: "x86_64-unknown-linux-gnu"
-        options:
-            - x86_64-unknown-linux-gnu
-            - aarch64-unknown-linux-gnu
-            - x86_64-apple-darwin
-            - aarch64-apple-darwin
-    github-token:
-        description: "GitHub token"
-        type: string
-        required: true
+name: Install Rust and protoc
+description: Install Rust toolchain and protobuf compiler
 
 runs:
     using: "composite"
     steps:
-        - name: Install Rust toolchain
+        - name: Install Rust toolchain (Windows)
+          if: runner.os == 'Windows'
+          shell: powershell
+          run: |
+              Write-Host "Using pre-installed Rust and MSVC on GitHub-hosted runner"
+
+              # Verify Rust is available
+              if (Get-Command rustc -ErrorAction SilentlyContinue) {
+                  $version = rustc --version
+                  Write-Host "Rust available: $version"
+
+                  # Install rustfmt and clippy components
+                  Write-Host "Installing rustfmt and clippy..."
+                  rustup component add rustfmt clippy
+
+                  Write-Host "Rust toolchain ready"
+              } else {
+                  Write-Host "ERROR: Rust not found"
+                  exit 1
+              }
+
+        - name: Install Rust toolchain (Unix)
+          if: runner.os != 'Windows'
           uses: dtolnay/rust-toolchain@stable
           with:
-              targets: ${{ inputs.target }}
               components: rustfmt, clippy
 
-        - name: Install protoc (protobuf)
+        - name: Install protoc (Windows)
+          if: runner.os == 'Windows'
+          shell: powershell
+          run: |
+              Write-Host "Installing protoc version 29.1..."
+              if (Get-Command choco -ErrorAction SilentlyContinue) {
+                  choco install protoc --version=29.1 -y
+                  Write-Host "protoc 29.1 installed successfully"
+              } else {
+                  Write-Host "ERROR: Chocolatey not available"
+                  exit 1
+              }
+
+        - name: Install protoc (Unix)
+          if: runner.os != 'Windows'
           uses: arduino/setup-protoc@v3
           with:
-              version: "25.1"
-              repo-token: ${{ inputs.github-token }}
+              version: "29.1"
+              repo-token: ${{ github.token }}