Open
Conversation
Aryex
force-pushed
the
alexl/fix-link-checker
branch
from
c6cd6ff to
6b28205
Compare
Aryex
force-pushed
the
alexl/fix-link-checker
branch
from
5f0b5a5 to
0a9123e
Compare
affonsov
reviewed
Feb 10, 2026
.github/workflows/ci-cd.yml
Outdated
| with: | ||
| package-manager: pnpm@10 | ||
|
|
||
| # We previously could not make lycheeverse/lychee-action@v2 work; |
Collaborator
There was a problem hiding this comment.
Don't need to add a comment saying what was happening previously. Just describe what happen in the current step
Collaborator
Author
There was a problem hiding this comment.
I think people will inevitably ask "Why not use lychee-action" for this, so it's good to have this comment to avoid people backtracking on this.
Collaborator
There was a problem hiding this comment.
At least we should pin the lychee version
Is it worth it open an issue to investigate why we can't use the action? is a problem of the action itself. I wonder if we should open an issue to the original repo
Collaborator
Author
There was a problem hiding this comment.
I updated it to check the markdown directly which seems to work a lot better now.
xShinnRyuu
reviewed
Feb 10, 2026
jeremyprime
reviewed
Feb 10, 2026
Aryex
force-pushed
the
alexl/fix-link-checker
branch
2 times, most recently
from
27bb319 to
b1095cf
Compare
Aryex
force-pushed
the
alexl/fix-link-checker
branch
from
a014525 to
4bc759a
Compare
Signed-off-by: Alex Le <Alex.Le@improving.com>
Signed-off-by: Alex Le <Alex.Le@improving.com>
Signed-off-by: Alex Le <Alex.Le@improving.com>
Aryex
force-pushed
the
alexl/fix-link-checker
branch
from
4bc759a to
adb9ae3
Compare
Signed-off-by: Alex Le <Alex.Le@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes our static link checking workflow by configuring it to check the markdown directly. Previously it was configured to check the statically built site.
Content Changes
Changed: package.json
Changed: lychee.toml
Changed: ci-cd.yml
REMOVED: all-pages.astro
Testing
Tested manually by introducing broken links.
Checklist
Before submitting the PR make sure the following are checked:
--signoffflag.pnpm buildruns successfully.