Added lint and formated all the files#56
Added lint and formated all the files#56Maayanshani25 wants to merge 1 commit intovalkey-io:mainfrom
Conversation
Maayanshani25
force-pushed
the
lint
branch
3 times, most recently
from
4960a54 to
db7ff13
Compare
Signed-off-by: Maayan Shani <maayan.shani@mail.huji.ac.il>
Maayanshani25
changed the title
|
I'm wondering if we should align with Valkey formatting standards, or keep Spring formatting standards (like this PR is currently doing). We could make use of the Spring Data Build formatting here. I assume there would be much fewer changes if we stuck with the Spring Data formatting standards. Should discuss with team to decide on what approach we want first. |
pom.xml
Outdated
| <artifactId>maven-javadoc-plugin</artifactId> | ||
| <version>${maven-javadoc-plugin.version}</version> | ||
| </plugin> | ||
| <!-- Flatten plugin for Maven Central deployment --> |
There was a problem hiding this comment.
The flatten plugin was removed, we need this. Make sure you have latest changes from main.
| <indent> | ||
| <tabs>true</tabs> | ||
| <spacesPerTab>2</spacesPerTab> | ||
| </indent> | ||
| <indent> | ||
| <spaces>true</spaces> | ||
| <spacesPerTab>4</spacesPerTab> | ||
| </indent> |
There was a problem hiding this comment.
Conflicting indentation rules, I assume it should just be 4.
| <exclude>**/protobuf/**</exclude> | ||
| <exclude>**/target/**</exclude> | ||
| </excludes> | ||
| <importOrder/> |
There was a problem hiding this comment.
If we use Spring Data formatting, they have import order file we would reference here (could put a copy in this repo).
| <googleJavaFormat> | ||
| <version>${spotless-google-java-format.version}</version> | ||
| <reflowLongStrings>true</reflowLongStrings> | ||
| <groupArtifact>com.google.googlejavaformat:google-java-format</groupArtifact> | ||
| </googleJavaFormat> |
There was a problem hiding this comment.
If we use Spring Data formatting, they have eclipse formatting file we would reference here (could put a copy in this repo).
2 participants
Followed the lint setup from valkey-glide and applied the same formatting rules here. Source
Added lint test to the CI.
When checking the pr focus only on
/pom.xmland/.github/workflows/lint.yml