Skip to content

fix: fixing issue with sklearn version #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

johnwalz97
Copy link
Contributor

@johnwalz97 johnwalz97 commented Dec 11, 2024

Internal Notes for Reviewers

The latest version of sklearn (1.6.0) has some issues. These only pop up when installing the library with pip due to differences between pip and poetry with dependency resolution. This PR adds a simple rule to ignore the broken version which should solve the issue with the integration tests and the documentation repo.

External Release Notes

@johnwalz97 johnwalz97 requested a review from cachafla December 11, 2024 21:04
@johnwalz97 johnwalz97 added bug Something isn't working internal Not to be externalized in the release notes labels Dec 11, 2024
Copy link
Contributor

PR Summary

This pull request updates the pyproject.toml file to exclude version 1.6.0 of the scikit-learn package. This change ensures that any version of scikit-learn can be used except for version 1.6.0, which might have been excluded due to compatibility issues or known bugs.

Test Suggestions

  • Verify that the project builds successfully with the updated scikit-learn version constraint.
  • Run the existing test suite to ensure no regressions occur with the exclusion of scikit-learn version 1.6.0.
  • Test the application with a version of scikit-learn other than 1.6.0 to ensure compatibility and functionality.
  • Check for any specific features or functionalities that rely on scikit-learn to ensure they work as expected with the new version constraint.

@johnwalz97 johnwalz97 merged commit 9f329a4 into prod Dec 11, 2024
9 checks passed
@johnwalz97 johnwalz97 deleted the hotfix/fix-listing-of-tasks-and-tags branch December 11, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal Not to be externalized in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants