Skip to content

Prod 2.5.25 to main #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 9, 2024
Merged

Prod 2.5.25 to main #260

merged 9 commits into from
Dec 9, 2024

Conversation

cachafla
Copy link
Contributor

@cachafla cachafla commented Dec 9, 2024

Internal Notes for Reviewers

Just bringing recent hotfixes back to main.

External Release Notes

@cachafla cachafla added the internal Not to be externalized in the release notes label Dec 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

PR Summary

This pull request addresses minor formatting issues in the README.md and README.pypi.md files of the ValidMind Library project. The changes involve removing unnecessary trailing spaces to ensure consistent formatting across the documentation files. These changes do not affect the functionality of the library or its dependencies.

Test Suggestions

  • Verify that the README.md and README.pypi.md files display correctly without formatting issues.
  • Check that the removal of trailing spaces does not affect the rendering of markdown elements in the documentation.
  • Ensure that the documentation links and references are still functional and correctly formatted.

juanmleng
juanmleng approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@juanmleng juanmleng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

AnilSorathiya
AnilSorathiya approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@AnilSorathiya AnilSorathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

johnwalz97
johnwalz97 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@johnwalz97 johnwalz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice ty 👍

@cachafla cachafla merged commit 2b6896b into main Dec 9, 2024
6 checks passed
@cachafla cachafla deleted the prod-2.5.25-to-main branch December 9, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnwalz97 johnwalz97 johnwalz97 approved these changes

@AnilSorathiya AnilSorathiya AnilSorathiya approved these changes

@juanmleng juanmleng juanmleng approved these changes

Assignees
No one assigned
Labels
internal Not to be externalized in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cachafla @johnwalz97 @AnilSorathiya @juanmleng