Skip to content

[SC 7682] Hotfix for run composite test missing 2 required #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AnilSorathiya
Copy link
Contributor

Internal Notes for Reviewers

The bug was introduced during the implementation of the title feature in the run_test interface.
Error:
TypeError: _run_composite_test() missing 2 required positional arguments: 'input_grid' and 'param_grid'
https://github.com/validmind/validmind-library/actions/runs/12165121877

@AnilSorathiya AnilSorathiya added bug Something isn't working internal Not to be externalized in the release notes labels Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

PR Summary

This pull request introduces enhancements to the run_test function in the validmind/tests/run.py file by adding two new parameters: input_grid and param_grid. These parameters are now passed to the function, potentially allowing for more flexible test configurations.

Additionally, a minor refactor is performed in the to_widget method of the validmind/vm_models/result/result.py file. The HTML return statement is simplified by removing unnecessary line breaks, which improves code readability without altering functionality.

Test Suggestions

  • Test the run_test function with various configurations of input_grid and param_grid to ensure they are correctly handled.
  • Verify that the addition of input_grid and param_grid does not break existing functionality.
  • Check the output of the to_widget method to ensure the HTML is rendered correctly after the refactor.
  • Perform regression testing on the to_widget method to confirm no unintended changes in behavior.

Copy link
Contributor

@johnwalz97 johnwalz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@cachafla cachafla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@AnilSorathiya AnilSorathiya merged commit ad744bb into main Dec 5, 2024
8 checks passed
@johnwalz97 johnwalz97 deleted the anilsorathiya/sc-7682/hotfix-for-run-composite-test-missing-2-required branch December 5, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal Not to be externalized in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants