Skip to content

chore: removing metrics references #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 4, 2024
Merged

chore: removing metrics references #252

merged 3 commits into from
Dec 4, 2024

Conversation

johnwalz97
Copy link
Contributor

@johnwalz97 johnwalz97 commented Nov 27, 2024 •
edited
Loading

Internal Notes for Reviewers

Removing any references to old metrics.

External Release Notes

@johnwalz97 johnwalz97 added internal Not to be externalized in the release notes chore Chore tasks that aren't bugs or new features labels Nov 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

PR Summary

This pull request updates the documentation comment in the result.py file within the validmind/vm_models/result directory. The change involves modifying the description from "Result Wrappers for test and metric results" to "Result Objects for test results". This update clarifies the purpose of the module, focusing on test results rather than both test and metric results.

Test Suggestions

  • Verify that the documentation change does not affect any functionality.
  • Ensure that all existing tests for result objects pass without modification.

@johnwalz97 johnwalz97 requested a review from cachafla December 2, 2024 19:09
cachafla
cachafla approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@cachafla cachafla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's it? 😅

@johnwalz97 johnwalz97 merged commit e1a3d69 into main Dec 4, 2024
6 checks passed
@johnwalz97 johnwalz97 deleted the john6797/sc-7220/table-consolidation-step-7-cleanup branch December 4, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cachafla cachafla cachafla approved these changes

Assignees
No one assigned
Labels
chore Chore tasks that aren't bugs or new features internal Not to be externalized in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnwalz97 @cachafla