Skip to content

Add notebook for implementing custom tests #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

nrichers
Copy link
Collaborator

@nrichers nrichers commented Jun 13, 2023

Related to this Slack convo from @mehdi0501, a PR that adds the new notebook from @cachafla.

We previously imbedded the related test notebooks via wildcard, but we likely want to have the one for custom notebooks appear after the other ones, so we now imbed the notebooks individually.

Output

image

External Release Notes

Test description 6 for documentation label.

@nrichers nrichers added the documentation Improvements or additions to documentation label Jun 13, 2023
@nrichers nrichers requested review from cachafla and mehdi0501 June 13, 2023 00:39
Copy link
Contributor

@cachafla cachafla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mehdi0501
Copy link
Contributor

looks good to me too

Copy link
Contributor

@mehdi0501 mehdi0501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me too

@nrichers nrichers merged commit 51e9bdb into main Jun 13, 2023
@nrichers nrichers deleted the add-custom-test-notebook branch June 22, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants