Skip to content

Removed references to editions in FAQ #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

validbeck
Copy link
Collaborator

@validbeck validbeck commented Feb 19, 2025

Internal Notes for Reviewers

sc-8527

I removed the references to the editions in the FAQ, and updated the data & privacy to simply include the bit about how we handle PII.

LIVE PREVIEW

Before After
Screenshot 2025-02-19 at 2 13 37 PM Screenshot 2025-02-19 at 2 34 05 PM
Screenshot 2025-02-19 at 2 13 48 PM n/a, removed
Screenshot 2025-02-19 at 2 13 53 PM Screenshot 2025-02-19 at 2 34 18 PM

Data privacy policy

There's still a blurb in the data privacy policy about editions — not sure if we want to expunge these as well?

Screenshot 2025-02-19 at 2 12 43 PM

@validbeck validbeck added the internal Not to be externalized in the release notes label Feb 19, 2025
@validbeck validbeck self-assigned this Feb 19, 2025
@validbeck validbeck requested a review from nrichers February 19, 2025 22:35
Copy link
Contributor

PR Summary

This pull request removes the FAQ section related to the different editions of the product from the site/faq/_faq-editions.qmd file and updates the privacy information in the site/faq/faq-privacy.qmd file. The changes include:

  • Deletion of the _faq-editions.qmd file, which contained information about the different editions of the product, including Standard, Enterprise, and VPV editions.
  • Removal of the inclusion of _faq-editions.qmd in faq-organizations.qmd and faq-privacy.qmd.
  • Direct inclusion of privacy-related information in faq-privacy.qmd, specifically about the handling of Personally Identifiable Information (PII) and the use of AWS PrivateLink for secure connectivity.
  • Updates to the footnotes in faq-privacy.qmd to include references for AWS PrivateLink and VPV.
  • Removal of the 'editions' category from the FAQ listing in faq.qmd for both 'Access and permissions' and 'Data handling and privacy' sections.

Test Suggestions

  • Verify that the FAQ page renders correctly without the editions section.
  • Check that the privacy information is correctly displayed in the 'Data handling and privacy' section.
  • Ensure that all links and footnotes in the updated privacy section are functional.
  • Test the FAQ navigation to confirm that categories are correctly updated and no broken links exist.

Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 I pushed b5a27b6 to remove the remaining edition references, reworking sentences to sidestep the issue. :shipit:

Copy link
Contributor

A PR preview is available: Preview URL

@validbeck validbeck merged commit 2daeb0d into main Feb 21, 2025
3 checks passed
@validbeck validbeck deleted the beck/sc-8527/remove-incorrect-edition-references branch February 21, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Not to be externalized in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants