Skip to content

Fix notebook link #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Fix notebook link #651

merged 1 commit into from
Feb 8, 2025

Conversation

nrichers
Copy link
Collaborator

@nrichers nrichers commented Feb 6, 2025

Internal Notes for Reviewers

Small fix for a broken link I noticed in our Jan 31 release notes

External Release Notes

@nrichers nrichers added the internal Not to be externalized in the release notes label Feb 6, 2025
@nrichers nrichers requested a review from validbeck February 6, 2025 23:50
Copy link
Contributor

github-actions bot commented Feb 6, 2025

PR Summary

This pull request addresses a bug in the release notes for January 31, 2025. The change corrects a malformed URL path in the release-notes.qmd file. Specifically, an extraneous closing parenthesis was removed from the URL path for a JupyterHub notebook link, ensuring that the link is now correctly formatted and functional.

Test Suggestions

  • Verify that the corrected URL in the release notes is accessible and leads to the intended JupyterHub notebook.
  • Check for any other similar URL formatting issues in the release notes or related documentation files.
  • Ensure that the release notes render correctly in the intended format (e.g., HTML, PDF).

Copy link
Contributor

github-actions bot commented Feb 7, 2025

A PR preview is available: Preview URL

Copy link
Collaborator

@validbeck validbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nrichers nrichers merged commit 926460f into main Feb 8, 2025
6 checks passed
@nrichers nrichers deleted the nrichers-patch-1 branch February 8, 2025 01:12
nrichers added a commit that referenced this pull request Feb 10, 2025
Co-authored-by: Nik Richers <nik@validmind.ai>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
nrichers added a commit that referenced this pull request Feb 14, 2025
* Adding latest `RawData` notebook to docs (#647)

* Pulling in latest RawData notebook

* Added notebook to testing overview

* Added notebook to FAQ - testing

* feat: make lighter version of docs-site target

* Fix notebook link (#651)

* Part 1 — +"Breaking changes and deprecation" page under releases to support the new processes (#650)

* Adding a breaking changes page

* Details

* Editing headers

* Adding product area

* Folder

* Testing R table

* It woooorks

* Setup for multiple entires & adding search back

* Adjusting test data for clarity

* Single-sourcing the functions

* Moving functions to scri[pt for cleaner exp

* Column widths back in

* Cleanup & templates

* Templating README

* Tweaking

* Adding version and type columns

* Filters for version & type

* Examples and more testing

* Intro to README

* Moved history into its own folder

* Instructions for +year

* Add an entry draft

* Entry example table

* Testing R setup

* Switching placement

* Forgot a package

* Cleanup & caching

* Forgot a package again

* Adding R env to staging & prod flows

* Naming the code cells for output cleanliness

* Removed fake 2025 example

* Wow, typo

* Wording adjustment

* Removed blog posts

* Fix notebook link (#651) (#654)

Co-authored-by: Nik Richers <nik@validmind.ai>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Define next iteration of training content (#649)

* Rough in some topics

* WIP content noodling

* Fix merge conflict

* Content rework

* Content edits

* Add mapping from questions to courses

* Content edits

* Updated content, move videos

* Update learning paths

* Update learning paths

* Expand learning paths

* Update learning paths, FAQ

* Edits

* Update course content

* Update FAQ

* Fix margin callout, shorten sample training plan

* Minor edits

* Add docs links to FAQ

* Update FAQ and learning paths

* Training FAQ updates

* Clean up temporary CSS, add small button CSS

* Hide .attn sections to be able to publish the page

* Update FAQ page formatting, add Pandas link

* Add some FAQ-elements

* Best offer for formatting an shenanigans

* Hide more working notes stuff, add .attn to learning path course cards

* More learning paths formatting improvements

* Simplify language and remove old file

* Add callouts to learning paths

* Modifying some style stuff

* Redoing buttons for readability

* Quick tweak to sidebar

* Overview rename & cleanup

* Reverting sidebar & toc for rest of site

* Update site/training/program/sample-training-plan.qmd

Co-authored-by: Beck <164545837+validbeck@users.noreply.github.com>

* Training sidebar tweaks

* Remove extra newline and commented out line

* Improve 'coming soon' text

---------

Co-authored-by: Beck <164545837+validbeck@users.noreply.github.com>

---------

Co-authored-by: Beck <164545837+validbeck@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Spencer Krum <nibz@validmind.ai>
Co-authored-by: Spencer Krum <nibz@spencerkrum.com>
@nrichers nrichers added bug Something isn't working documentation Improvements or additions to documentation and removed internal Not to be externalized in the release notes labels Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants