-
Notifications
You must be signed in to change notification settings - Fork 4
Add Docker image for our docs site #594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nrichers
merged 4 commits into
main
from
nrichers/sc-7705/create-docker-image-for-docs-site
Dec 18, 2024
Merged
Add Docker image for our docs site #594
nrichers
merged 4 commits into
main
from
nrichers/sc-7705/create-docker-image-for-docs-site
Dec 18, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR SummaryThis pull request introduces Docker support for building and serving the static HTML site. The changes include:
These changes enable users to deploy the static site in a consistent environment using Docker, facilitating both local testing and production deployment. Test Suggestions
|
A PR preview is available: Preview URL |
1 similar comment
A PR preview is available: Preview URL |
nibalizer
approved these changes
Dec 17, 2024
nibalizer
reviewed
Dec 17, 2024
A PR preview is available: Preview URL |
nrichers
added a commit
that referenced
this pull request
Dec 18, 2024
* Add Dockerfile, make docker-image action, and update readme * Remove stray text * Minor comment update * Split make action into docker-build and docker-serve Co-authored-by: Nik Richers <nik@validmind.ai> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal Notes for Reviewers
For self-hosted installations, we agreed to create a Docker image that can be shipped with the rest of the product. This PR adds:
Dockerfile
— Uses the rendered site output insite/_site
and turns it into a Docker image that can be served on port 4444make docker-build
— Fetches the source files, renders the docs site, and builds the imagemake docker-serve
— Serves the docs site locally for testing on port 4444README.md
— Explains the aboveI also updated the mostly unused
docs-site
action to use ourproduction
profile. We don't use this action as part of our workflow generally, so it should be fine to repurpose for the Docker image.Proof it works
Relevant bits from
make docker-image
: [EDIT — INFO IS FROM BEFORE SPLITTING THE MAKE ACTION]What Docker shows:
And finally, accessing the site locally:
We use port 4444 since this is a Quarto site and this is what I already use locally.
External Release Notes