Skip to content

Fix link to SR 11-7 #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2024
Merged

Fix link to SR 11-7 #588

merged 1 commit into from
Dec 12, 2024

Conversation

nrichers
Copy link
Collaborator

@nrichers nrichers commented Dec 12, 2024 •
edited
Loading

Internal Notes for Reviewers

Kevin pointed out this link to SR 11-7 in our glossary is broken, now fixed.

EDIT: Did a quick search through the repo and this looks to be the only occurrence of this particular malformed link.

External Release Notes

@nrichers nrichers added bug Something isn't working internal Not to be externalized in the release notes labels Dec 12, 2024
@nrichers nrichers requested a review from validbeck December 12, 2024 18:39
@github-actions GitHub Actions
Copy link
Contributor

PR Summary

This pull request addresses a broken hyperlink in the glossary section of the site. Specifically, it corrects the URL in the definition of 'model' under the 'Models' section. The link previously pointed to an incorrect URL (sr1107.html) and has been updated to the correct URL (sr1107.htm). This change ensures that users can access the referenced document on Model Risk Management guidance without encountering a 404 error.

Test Suggestions

  • Verify that the updated link in the glossary section correctly navigates to the intended document on Model Risk Management.
  • Check for any other instances of broken links within the glossary or related sections.
  • Ensure that the glossary page renders correctly after the link update.

@github-actions GitHub Actions
Copy link
Contributor

A PR preview is available: Preview URL

validbeck
validbeck approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@validbeck validbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird! 🚀

@nrichers nrichers merged commit 5d4256b into main Dec 12, 2024
7 checks passed
@nrichers nrichers deleted the nrichers-patch-1 branch December 12, 2024 18:56
@validbeck validbeck mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@validbeck validbeck validbeck approved these changes

Assignees
No one assigned
Labels
bug Something isn't working internal Not to be externalized in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nrichers @validbeck