Live notebook execution workflows, take ... whatever #567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal Notes for Reviewers
I keep saying I'm giving up but then I don't... anyway.
The LAST attempt gave me some interesting info in the logs. It did properly check against the correct
base
(staging
) with the current commit aligning to the PR branch that was being merged in, but it still told me there was no difference in files:Presumably because when the
merge-main-into-staging.yaml
workflow is complete, there ARE no changes in betweenstaging
and the commit being compared, because it's already been smushed in...And so, I am trying to explicitly call the commit PRIOR to the most recent commit:
I am hoping this will work. When I call
git show HEAD~1
when I am on staging, I get the following info:Which aligns with the last commit PRIOR to the last commit that was auto-merged in by the
merge-main-into-staging.yaml
workflow, so in theory the next time the workflows run it will retrieve the right commit to compare against. In theory. (It would help if I knew what I was doing.)