-
Notifications
You must be signed in to change notification settings - Fork 4
Add login button to docs site #544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add login button to docs site #544
Conversation
PR SummaryThis pull request introduces enhancements to the website's navigation menu by adding a 'Login' section with multiple login options. The changes include:
Test Suggestions
|
A PR preview is available: Preview URL |
A PR preview is available: Preview URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ub.com:validmind/documentation into nrichers/sc-7484/add-login-button-to-docs-site
A PR preview is available: Preview URL |
1 similar comment
A PR preview is available: Preview URL |
* Add login button & switch search * Tweak login options * Padding? * Ughhh padding * Add VPV to login options * Wording tweak --------- Co-authored-by: Nik Richers <nik@validmind.ai> Co-authored-by: Beck <164545837+validbeck@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@nrichers I was able to locate the original conversation where I tried to implement the overlay search and you advised against it — I know some of the reason was the solution I had in that PR removed the landing search from the main page and I agree the trade-off in that instance wasn't acceptable, but the following still applies:
Is there a reason why we decided this is now worth the extra click? I'm in favour of it, just trying to understand the logic of what else shifted. |
Yes, we reimplemented the search on the front page of the docs, in preparation for future enhancements like the chatbot. Given how the old search box was implemented on front page ('I macgyvered it'), we could not switch to the search icon without losing the search box. |
Internal Notes for Reviewers
This PR adds a Login button & menu to our docs site. If this format works for you, we can ask CSTMR to add the same button to our main site: LIVE PREVIEW
As part of this change, I'm also switching the search over to the navbar icon — it helps with spacing for the Login button and helps differentiate how search on the front page is subtly different from search that is available elsewhere.
How it works:
External Release Notes
We added the option to log in to the ValidMind Platform to our docs site, making it easy for you to find the right login. Click Login to try it out.