Skip to content

Replace Output Template Notebook from Highlighted Code Samples #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

johnwalz97
Copy link
Contributor

@johnwalz97 johnwalz97 commented Nov 21, 2024

Internal Notes for Reviewers

Since we are dropping support for output templates, the code sample notebook for output templates is no longer relevant. This change replaces it with a more relevant notebook on integrating external test providers.

External Release Notes

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024

CLA assistant check
All committers have signed the CLA.

@johnwalz97 johnwalz97 added internal Not to be externalized in the release notes deprecation Feature to be removed for the release notes labels Nov 21, 2024
Copy link
Contributor

PR Summary

This pull request updates a reference in the developer guide documentation. Specifically, it changes the path of a notebook in the get-started-validmind-library.qmd file from customization/customizing_tests_with_output_templates.ipynb to custom_tests/integrate_external_test_providers.ipynb. This change likely reflects an update in the organization or content of the code samples, ensuring that the documentation points to the correct and intended resource.

Test Suggestions

  • Verify that the new notebook path custom_tests/integrate_external_test_providers.ipynb exists and is accessible.
  • Check that the content of the new notebook is relevant and correctly linked in the context of the documentation.
  • Ensure that the documentation builds correctly without errors after the path update.

Copy link
Contributor

A PR preview is available: Preview URL

Copy link
Collaborator

@validbeck validbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @johnwalz97!

Looks like we were already using the external test provider notebook in most other places, so this should be sufficient.

Copy link
Contributor

A PR preview is available: Preview URL

@validbeck validbeck merged commit 6ee0dcc into main Nov 26, 2024
3 checks passed
@validbeck validbeck deleted the john/remove-output-templates-notebook branch November 26, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Feature to be removed for the release notes internal Not to be externalized in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants