Skip to content

Update archive-delete-models.qmd #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

mehdi0501
Copy link
Contributor

adding a note that only admin users can see archived models

Internal Notes for Reviewers

External Release Notes

adding a note that only admin users can see archived models
@mehdi0501 mehdi0501 requested a review from validbeck November 21, 2024 17:06
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

PR Summary

This pull request enhances the model archival and deletion process in the model inventory guide. The changes include:

  • Clarification that once a model is archived, it can either be deleted or reactivated.
  • Introduction of a note specifying that, by default, only Admin users have the permission to view and delete archived models. This is a configurable user permission setting.

These changes aim to improve the clarity and functionality of the model management process within the system.

Test Suggestions

  • Verify that the documentation correctly reflects the ability to delete or reactivate a model after it has been archived.
  • Check that the note about admin permissions is accurately displayed and understandable.
  • Ensure that the user permission configuration for viewing and deleting archived models is functioning as described.

Copy link
Contributor

A PR preview is available: Preview URL

@validbeck
Copy link
Collaborator

@mehdi0501 The condition for only admins being able to see archived model is already at the top of this page: LIVE LINK

Screenshot 2024-11-21 at 9 36 06 AM

This has a footnote that links to the permissions page that talks about being able to adjust for roles.

Re:

Once a model has been archived, you can then proceed with deleting the model or making it active again

I had a talk with @nrichers once about "simplicity" — for example, not calling out the cancel action for instructions unless they are a totally complete step (in this case, the "make it active again").

How about this? I made a parallel PR so not to override your changes without permission to give the copy in that section some clarity: #538

That PR pulls in your suggestions from this one so it's also authored by both of us. :)

@validbeck validbeck added the DO NOT MERGE PR is not ready to be merged label Nov 26, 2024
@validbeck validbeck closed this Nov 26, 2024
@validbeck validbeck deleted the mehdi0501-patch-1 branch November 26, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE PR is not ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants