Skip to content

Quick CSS cleanup #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Quick CSS cleanup #531

merged 3 commits into from
Nov 19, 2024

Conversation

validbeck
Copy link
Collaborator

@validbeck validbeck commented Nov 18, 2024

Internal Notes for Reviewers

  • Reverted the training/training.qmd (training landing page) top nav to white for contrast with the special hero banner
  • Fixed the disappearing footer hover links
  • Adjusted the video border convention
Old New
Screenshot 2024-11-18 at 10 04 59 AM Screenshot 2024-11-18 at 10 25 15 AM
Screenshot 2024-11-18 at 10 05 11 AM Screenshot 2024-11-18 at 10 25 26 AM
Screenshot 2024-11-18 at 10 05 21 AM Screenshot 2024-11-18 at 10 25 34 AM

@validbeck validbeck added the internal Not to be externalized in the release notes label Nov 18, 2024
@validbeck validbeck self-assigned this Nov 18, 2024
@validbeck validbeck requested a review from nrichers November 18, 2024 18:26
Copy link
Contributor

PR Summary

This pull request introduces several style updates across the project to ensure consistency in the visual appearance of embedded elements and navigation links. The changes include:

  1. Border Color Update: The border color for embedded iframes and video elements has been changed from #DE257E to #196972 in multiple files, including conventions.qmd, release-notes.qmd, and styles.css.

  2. Navigation Link Styles: Adjustments have been made to the CSS selectors for navigation links to include a new hover style for footer links, ensuring they change color to #1A202C without text decoration.

  3. Navbar Background Color: A new inline style has been added to training.qmd to set the navbar background color to white, overriding any existing styles.

These changes aim to provide a more cohesive and visually appealing user interface across the site.

Test Suggestions

  • Verify that the border color of iframes and video elements is updated to #196972 across all affected pages.
  • Check that the hover effect on footer navigation links changes the text color to #1A202C without any text decoration.
  • Ensure that the navbar background color is white on the training page and that it overrides any other styles.
  • Test the site on different browsers to ensure consistent styling and appearance.
  • Check for any visual regressions on pages where styles have been modified.

Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, @validbeck. 🙇

@validbeck validbeck merged commit 378fa85 into main Nov 19, 2024
7 checks passed
@validbeck validbeck deleted the beck/css-cleanup branch November 19, 2024 17:41
validbeck added a commit that referenced this pull request Nov 20, 2024
* Missed a graphic change

* Deleting the old image

* developer-framework repo > validmind-library repo

* Quick CSS cleanup (#531)

* Reverted training.qmd topbav to white bg

* Fixed disappearing footer hover links

* Adjusted video border

* Fixed weird columns on releases: 2024-jan-18 & 2024-may-22

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Not to be externalized in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants