Skip to content

Documentation for filtering test result metadata #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

validbeck
Copy link
Collaborator

Internal Notes for Reviewers

sc-6911

Work with test results

Added a new sub-section under View test result metadata to reflect the new filtering option:

Screenshot 2024-11-04 at 11 41 53 AM
  • Gif has been updated to reflect the new UI
  • There is a commented out section for "pinning" historical test results for when that is ready to be exposed to end-users

@validbeck validbeck added the internal Not to be externalized in the release notes label Nov 4, 2024
@validbeck validbeck self-assigned this Nov 4, 2024
@validbeck
Copy link
Collaborator Author

validbeck commented Nov 4, 2024

@lucaspazneutech If these instructions look good to you, can you please approve? 🙏🏻

LIVE PREVIEW

Screenshot 2024-11-04 at 11 41 53 AM

Copy link
Contributor

github-actions bot commented Nov 4, 2024

PR Summary

This pull request introduces several enhancements to the documentation and styling of the project:

  1. Documentation Enhancements:

    • Added a section on filtering historical test results in the work-with-test-results.qmd file. Users can now filter test results by date range, model, dataset, and the person who ran the test.
    • Updated instructions for resolving comments and suggested changes in the collaborate-with-others.qmd and _collaborate-with-others-comments.qmd files to use a more consistent styling approach.
    • Clarified the process of filtering model findings in the view-filter-model-findings.qmd file.
  2. Styling Updates:

    • Introduced new CSS classes in styles.css for consistent styling of text and backgrounds, including .green-bg, .pink, .green, and .red.
    • Updated the index page to use the new .pink class for styling text.

These changes aim to improve the usability and visual consistency of the documentation, making it easier for users to navigate and understand the available features.

Test Suggestions

  • Verify that the new filtering functionality in the documentation is correctly described and matches the actual application behavior.
  • Check that the new CSS classes are applied correctly across the documentation and that they render as expected in different browsers.
  • Ensure that the updated instructions for resolving comments and suggested changes are clear and accurate.
  • Test the documentation site to ensure that all links and images are functioning correctly after the updates.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

PR Summary

This pull request introduces several enhancements to the documentation of the project:

  1. Test Result Filtering: Added functionality to filter historical test results based on criteria such as date range, model, dataset, and run by. This allows users to narrow down test runs and manage test result metadata more effectively.

  2. Styling Updates: Introduced new CSS classes for consistent styling across the documentation. These include .green-bg for background highlighting, and .green, .red, and .pink for text color styling. These changes improve the visual clarity and consistency of the documentation.

  3. Documentation Improvements: Updated various documentation files to use the new styling classes for better readability and user experience. This includes changes in how suggested changes and comments are displayed and resolved.

Overall, these changes aim to enhance the usability and visual appeal of the documentation, making it easier for users to interact with and understand the content.

Test Suggestions

  • Verify that the filtering functionality for test results works as expected with various criteria.
  • Check that the new CSS classes are applied correctly across different documentation pages.
  • Ensure that the documentation displays correctly in different browsers and screen sizes.
  • Test the interaction with the test result metadata to confirm that filters can be applied and removed without issues.
  • Review the documentation for any visual inconsistencies or errors introduced by the new styling.

Copy link

@lucaspazneutech lucaspazneutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here!

Copy link
Contributor

github-actions bot commented Nov 6, 2024

A PR preview is available: Preview URL

@validbeck validbeck merged commit 62b681e into main Nov 6, 2024
3 checks passed
@validbeck validbeck deleted the beck/sc-6911/documentation-filtering-test-result-metadata branch November 6, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Not to be externalized in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants