Skip to content

Fix merge conflicts for Sep 20 #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 83 commits into from
Sep 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
83 commits
Select commit Hold shift + click to select a range
0148010
Merging latest changes from main into staging
github-actions[bot] Aug 29, 2024
abc32ee
Merge pull request #299 from validmind/update-staging-10623213763
github-actions[bot] Aug 29, 2024
8df73c6
Merging latest changes from main into staging
nrichers Aug 29, 2024
82c4270
Merging latest changes from main into staging
github-actions[bot] Aug 30, 2024
7d2d515
Merge pull request #301 from validmind/update-staging-10625320248
github-actions[bot] Aug 30, 2024
814a8cf
Merging latest changes from main into staging
github-actions[bot] Aug 30, 2024
f3ad3ec
Merge pull request #302 from validmind/update-staging-10634123142
github-actions[bot] Aug 30, 2024
f45b7a4
Merging latest changes from main into staging
github-actions[bot] Aug 30, 2024
e97bcee
Merge pull request #303 from validmind/update-staging-10634380236
github-actions[bot] Aug 30, 2024
baaaec0
[create-pull-request] automated change
nrichers Aug 30, 2024
aa2fd06
Merge pull request #304 from validmind/update-staging-10634497929
github-actions[bot] Aug 30, 2024
87cabda
Merging latest changes from main into staging
github-actions[bot] Aug 30, 2024
53b8990
Merge pull request #305 from validmind/update-staging-10634538944
github-actions[bot] Aug 30, 2024
13920c3
Merging latest changes from main into staging
github-actions[bot] Aug 30, 2024
80bdb1d
Merge pull request #306 from validmind/update-staging-10635202446
github-actions[bot] Aug 30, 2024
e833a70
Merging latest changes from main into staging
github-actions[bot] Sep 3, 2024
8010178
Merge pull request #310 from validmind/update-staging-10687713356
github-actions[bot] Sep 3, 2024
b1eca80
Merging latest changes from main into staging
github-actions[bot] Sep 3, 2024
6b75887
Merge pull request #311 from validmind/update-staging-10687966855
github-actions[bot] Sep 3, 2024
123baac
Merging latest changes from main into staging
github-actions[bot] Sep 3, 2024
d0bc99c
Merge pull request #312 from validmind/update-staging-10687983454
github-actions[bot] Sep 3, 2024
ae39818
Merging latest changes from main into staging
github-actions[bot] Sep 3, 2024
94a2fe4
Merge pull request #314 from validmind/update-staging-10688064600
github-actions[bot] Sep 3, 2024
0b0bf0c
Merge branch 'staging' of github.com:validmind/documentation into sta…
nrichers Sep 3, 2024
f7c167b
Merging latest changes from main into staging
github-actions[bot] Sep 3, 2024
8c6eda9
Merge pull request #318 from validmind/update-staging-10690658343
github-actions[bot] Sep 3, 2024
7afce17
Update rendered site
nrichers Sep 3, 2024
e6f2ae9
Merging latest changes from main into staging
github-actions[bot] Sep 4, 2024
4beb606
Merge pull request #327 from validmind/update-staging-10710813001
github-actions[bot] Sep 4, 2024
bc0855d
Delete site/_site directory in staging (#326)
nrichers Sep 5, 2024
959f491
Delete site/_site directory in prod (#328)
nrichers Sep 5, 2024
d5fe101
Merging staging into prod (#331)
validbeck Sep 5, 2024
0474879
Merging latest changes from main into staging
github-actions[bot] Sep 6, 2024
0d85544
Merge pull request #332 from validmind/update-staging-10730152504
github-actions[bot] Sep 6, 2024
2e442f1
Merging latest changes from main into staging
github-actions[bot] Sep 6, 2024
5805f80
Merge pull request #333 from validmind/update-staging-10730156583
github-actions[bot] Sep 6, 2024
b687ac9
Merging latest changes from main into staging
github-actions[bot] Sep 6, 2024
548d53e
Merge pull request #335 from validmind/update-staging-10743615533
github-actions[bot] Sep 6, 2024
0f78590
Merging latest changes from main into staging
github-actions[bot] Sep 6, 2024
2e2f0f0
Merge pull request #337 from validmind/update-staging-10745632571
github-actions[bot] Sep 6, 2024
f048929
Merge staging into prod (#338)
nrichers Sep 6, 2024
5a62177
Delete .github/workflows/render-site.yaml (#344)
nrichers Sep 9, 2024
b2987ff
Merging latest changes from main into staging
github-actions[bot] Sep 9, 2024
dedc4ee
Merge pull request #345 from validmind/update-staging-10779461419
github-actions[bot] Sep 9, 2024
a656767
Merging latest changes from main into staging
github-actions[bot] Sep 9, 2024
62a3b52
Merge pull request #346 from validmind/update-staging-10779486310
github-actions[bot] Sep 9, 2024
f00cfbe
Pushing changes from `staging` into `prod` (#347)
validbeck Sep 9, 2024
e7ab053
Fix heap embeds for docs sites — staging branch (#340)
nrichers Sep 9, 2024
a1c442b
Merging latest changes from main into staging
github-actions[bot] Sep 12, 2024
c092a0e
Merge pull request #353 from validmind/update-staging-10837056322
github-actions[bot] Sep 12, 2024
0a663e6
Merging latest changes from main into staging
github-actions[bot] Sep 12, 2024
5effc44
Merge pull request #354 from validmind/update-staging-10837149819
github-actions[bot] Sep 12, 2024
5174a56
Merging latest changes from main into staging
github-actions[bot] Sep 12, 2024
c597efd
Merge pull request #356 from validmind/update-staging-10838565124
github-actions[bot] Sep 12, 2024
f2a594e
Merging latest changes from main into staging
github-actions[bot] Sep 12, 2024
f1be162
Merge pull request #357 from validmind/update-staging-10839075611
github-actions[bot] Sep 12, 2024
cd1fd93
Merging latest changes from main into staging
github-actions[bot] Sep 12, 2024
0c4a25d
Merge pull request #359 from validmind/update-staging-10840017604
github-actions[bot] Sep 12, 2024
0237d86
Merging latest changes from main into staging
github-actions[bot] Sep 12, 2024
fe7627f
Merge pull request #360 from validmind/update-staging-10840290103
github-actions[bot] Sep 12, 2024
88ac0f4
Merging latest changes from main into staging
github-actions[bot] Sep 13, 2024
d05a9eb
Merge pull request #364 from validmind/update-staging-10857170672
github-actions[bot] Sep 13, 2024
eacb899
Merge staging into prod fix conflicts (#365)
nrichers Sep 13, 2024
63acb73
Publishing changes from PR #340 onwards (#362)
validbeck Sep 13, 2024
583556a
Merging latest changes from main into staging
github-actions[bot] Sep 16, 2024
e9fc4da
Merge pull request #367 from validmind/update-staging-10890697295
github-actions[bot] Sep 16, 2024
b749c3f
Merging latest changes from main into staging
github-actions[bot] Sep 16, 2024
7c4736a
Merge pull request #370 from validmind/update-staging-10893066487
github-actions[bot] Sep 16, 2024
df98f9f
Merging latest changes from main into staging
github-actions[bot] Sep 16, 2024
150248a
Merge pull request #371 from validmind/update-staging-10893081950
github-actions[bot] Sep 16, 2024
10d99cd
Merging latest changes from main into staging
github-actions[bot] Sep 17, 2024
892f784
Merge pull request #374 from validmind/update-staging-10908524111
github-actions[bot] Sep 17, 2024
273fd3a
Merging latest changes from main into staging
github-actions[bot] Sep 17, 2024
a5f62dc
Merge pull request #384 from validmind/update-staging-10911746021
github-actions[bot] Sep 17, 2024
b73f018
Merging latest changes from main into staging
github-actions[bot] Sep 19, 2024
28a3dbd
Merge pull request #411 from validmind/update-staging-10948808034
github-actions[bot] Sep 19, 2024
89bb0b8
Merging latest changes from main into staging
github-actions[bot] Sep 19, 2024
97b71ed
Merge pull request #413 from validmind/update-staging-10950664176
github-actions[bot] Sep 19, 2024
790cc1b
Merging latest changes from main into staging
github-actions[bot] Sep 20, 2024
94582c1
Merge pull request #414 from validmind/update-staging-10951603725
github-actions[bot] Sep 20, 2024
f1e3298
Merging latest changes from main into staging
github-actions[bot] Sep 20, 2024
4d4eb8e
Merge pull request #416 from validmind/update-staging-10962916677
github-actions[bot] Sep 20, 2024
321ff56
Merge branch 'staging' of github.com:validmind/documentation into fix…
nrichers Sep 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions site/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,16 @@ deploy-staging:
quarto render --profile staging && aws s3 sync ./_site s3://docs-ci-cd-staging/site/ --delete && aws cloudfront create-invalidation --distribution-id E2FB73KGY63MV6 --paths "/*" --no-cli-pager > /dev/null; \
fi

# Deployment to https://docs.validmind.ai/
# TO DO Fix Cloudfront distribution ID
deploy-staging:
@if [ "`git rev-parse --abbrev-ref HEAD`" != "nrichers/sc-6277/deploy-staging-docs-site-workflow" ]; then \
echo "You're not on the staging branch, no action taken."; \
else \
echo "\nDeploying staging site ..."; \
quarto render && aws s3 sync ./_site s3://docs-ci-cd-staging/site/ --delete && aws cloudfront create-invalidation --distribution-id E2FB73KGY63MV6 --paths "/*" --no-cli-pager > /dev/null; \
fi

# Generate release notes
release-notes:
@python ../release-scripts/generate_release_objects.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,4 +88,6 @@

::::

::::

Once saved, your new template version becomes available for use.
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
The **Model Activity** page shows a record of all activities, including actions performed by users in your organization and updates generated via the {{< var vm.developer >}} such as:

:::: {.content-visible unless-format="revealjs"}
- Inventory fields updated on the model^[[Edit model inventory fields](/guide/model-inventory/edit-model-inventory-fields.qmd)]
- Model status transitions^[[Working with model workflows](/guide/model-workflows/working-with-model-workflows.qmd)]
- Updates to model documentation, validation reports,^[[Working with model documentation](working-with-model-documentation.qmd)] or ongoing monitoring reports^[[Ongoing monitoring](/guide/monitoring/ongoing-monitoring.qmd)]
- Test results added to your model^[[ValidMind Developer Framework](/developer/get-started-developer-framework.qmd)]
- Findings added, updated, or removed^[[Working with model findings](/guide/model-validation/working-with-model-findings.qmd)]
- Comment creation and replies^[[Collaborate with others (Commenting)](/guide/model-documentation/collaborate-with-others.qmd#commenting)]

::::

:::: {.content-hidden unless-format="revealjs"}
- Inventory fields updated on the model
- Model or documentation status transitions
- Updates to model documentation, validation reports, or ongoing monitoring reports
- Test results added to your model
- Findings added, updated, or removed
- Comment creation and replies

::::
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
To view model activity:

:::: {.content-visible unless-format="revealjs"}
1. In the left sidebar, click **Model Inventory**.

1. Select a model by clicking on it or find your model by applying a filter or searching for it.^[[Working with the model inventory](/guide/model-inventory/working-with-model-inventory.qmd#search-filter-and-sort-models)]

1. In the expanded sidebar that appears for your model, click **Model Activity**.

::::

:::: {.content-hidden unless-format="revealjs"}
1. In the left sidebar, click **Model Inventory**.

1. Select a model by clicking on it or [find your model by applying a filter or searching for it](/guide/model-inventory/working-with-model-inventory.qmd#search-filter-and-sort-models).

1. In the expanded sidebar that appears for your model, click **Model Activity**.
::::


84 changes: 84 additions & 0 deletions site/guide/model-documentation/view-documentation-activity.qmd
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
---
title: "View documentation activity"
date: last-modified
---

Use the audit trail functionality in the {{< var validmind.platform >}} to track or audit all the information events associated with a specific model.

::: {.prereq}

## Prerequisites

<!-- ::: {.callout}
This topic matters for model developers, model validators, and auditors.
::: -->

- [x] {{< var link.login >}}
- [x] The model you are documenting is registered in the model inventory.[^1]
- [x] A model developer has started generating documentation, either using the {{< var vm.developer >}}[^2] or via the online UI editor.

:::

## Model Activity

{{< include _view-documentation-activity-overview.qmd >}}

{{< include _view-documentation-activity-steps.qmd >}}

### Filter activity

Use the top tabs to narrow down model activity.

#### All

Default view; shows all activity.

#### Comments

Shows only comments created or replied to; shows all comments by default.[^3]

Toggle mentions
: - Untoggle [**show all comments**]{.smallcaps} to see only comments you're mentioned in.
- Toggle [**show only mentions**]{.smallcaps} to show all comments again.

#### Status updates

Shows model status transitions.[^4]

#### Project updates

Shows project level updates:

- Inventory fields updated on the model[^5]
- Updates to model documentation, validation reports,[^6] or ongoing monitoring reports[^7]
- Test results added to your model[^8]
- Findings added, updated, or removed[^9]


## What's next

- [Working with model documentation](working-with-model-documentation.qmd)
- [Collaborate on documentation](collaborate-with-others.qmd)


<!-- FOOTNOTES -->

[^1]: [Register models in the inventory](/guide/model-inventory/register-models-in-inventory.qmd)

[^2]: [{{< var validmind.developer >}}](/developer/get-started-developer-framework.qmd)

[^3]: [Collaborate with others (Commenting)](/guide/model-documentation/collaborate-with-others.qmd#commenting)

[^4]: [Working with model workflows](/guide/model-workflows/working-with-model-workflows.qmd)

[^5]: [Edit model inventory fields](/guide/model-inventory/edit-model-inventory-fields.qmd)

[^6]: [Working with model documentation](working-with-model-documentation.qmd)

[^7]: [Ongoing monitoring](/guide/monitoring/ongoing-monitoring.qmd)

[^8]: [ValidMind Developer Framework](/developer/get-started-developer-framework.qmd)

[^9]: [Working with model findings](/guide/model-validation/working-with-model-findings.qmd)


Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
:::: {.content-visible unless-format="revealjs"}
1. In the left sidebar, click **Model Inventory**.

1. Select a model by clicking on it or find your model by applying a filter or searching for it.^[[Working with the model inventory](/guide/model-inventory/working-with-model-inventory.qmd#search-filter-and-sort-models)]

1. In the left sidebar that appears for your model, click **Documentation**.

You can now either log a finding on this overview page, or via a specific documentation section. Both methods will allow you to associate a finding with a documentation section.

::::

:::: {.content-hidden unless-format="revealjs"}
1. Select a model by clicking on it or [find your model by applying a filter or searching for it](/guide/model-inventory/working-with-model-inventory.qmd#search-filter-and-sort-models).

1. In the left sidebar that appears for your model, click **Documentation**.

You can now either log a finding on this overview page, or via a specific documentation section. Both methods will allow you to associate a finding with a documentation section.

::::



138 changes: 138 additions & 0 deletions site/guide/model-validation/add-update-model-findings.qmd
Original file line number Diff line number Diff line change
@@ -0,0 +1,138 @@
---
title: "Add and update model findings"
date: last-modified
---

Add findings within the {{< var validmind.platform >}} at the model or documentation section level, and update your findings to include proposed remediation plans and supporting documentation.

::: {.prereq}

## Prerequisites

- [x] {{< var link.login >}}
- [x] The model is already registered in the model inventory.[^1]
- [x] Model documentation is completed or in progress for your model.[^2]
- [x] You are a `Validator` or assigned another role with sufficient permissions to perform the tasks in this guide.[^3]

:::

## Add model findings

{{< include _add-model-findings.qmd >}}

#### Add finding via overview

To log a finding from the documentation overview:

1. On your model's **Documentation** page, click **{{< fa plus >}} Add Finding**.

2. On the **Add Model Finding** page that opens, provide information for:

- Title
- Risk area
- Owner
- Severity
- Due date
- Documentation section
- Description

3. When you are done, click **Save** to submit the finding.

Once created, you can then add supporting documentation to your finding.[^4]

#### Add finding via section

While working within a section of your documentation, you can easily log a finding associated with that section without leaving the page:

1. Click on **ValidMind Insights™** to expand the insight panel.

2. For the section you want to add a Finding for, click **{{< fa triangle-exclamation >}} Add Finding** beneath the Documentation Guidelines.

3. On the **Add Model Finding** page that opens, provide information for:

- Title
- Risk area
- Owner
- Severity
- Due date
- Documentation section
- Description

The documentation section will be auto-populated with the section you are working from — you are able to select another section if desired.

![](add-section-finding.gif){width=80% fig-alt="An animated gif demonstrating how to add a finding with the ValidMind Insights™ panel"}

4. When you are done, click **Save** to submit the finding.

Once created, you can then add supporting documentation to your finding.[^5]

## Update model findings

As findings get resolved or require other changes during the model validation process, you can update them:

1. Locate the finding you want to update.[^6]

2. Click on a field to make changes. You can make updates to:

- Title
- Description
- Proposed remediation plan
- Supporting documentation[^7]
- Status
- Severity
- Risk area
- Due date
- Assignee
- Documentation section

You can also add comments to a finding.

Most updates are applied immediately but you must click **Save** to make changes to the finding title, description, proposed remediation plan, and attachments effective.

### Manage supporting documentation

After a finding is created, you're able to add supporting documentation to it.

#### Add attachment to finding

::: {.callout}
Uploaded files must be less than 50 MB in size.
:::

1. On the findings detail page, click on the **[attachments]{.smallcaps}** header.

2. Click **{{< fa circle-plus >}} Add Attachment** to select a file.

3. Click **Save** to submit the upload.

#### Remove attachment from finding

1. On the findings detail page, click on the **[attachments]{.smallcaps}** header.

2. Locate the file you want to remove.

- Click **{{< fa trash-can>}}** to remove the file.
- After you confirm, the attachment will be removed from the list.

3. Click **Save** to apply the deletion.

After you save, the attachment will be removed permanently.

![](delete-finding-attachment.gif){width=80% fig-alt="An animated gif demonstrating how to delete an attachment from a finding"}


<!-- FOOTNOTES -->

[^1]: [Register models in the inventory](/guide/model-inventory/register-models-in-inventory.qmd)

[^2]: [Working with model documentation](/guide/model-documentation/working-with-model-documentation.qmd)

[^3]: [Manage permissions](/guide/configuration/manage-permissions.qmd)

[^4]: [Manage supporting documentation](#manage-supporting-documentation)

[^5]: [Manage supporting documentation](#manage-supporting-documentation)

[^6]: [View and filter model findings](view-filter-model-findings.qmd)

[^7]: [Manage supporting documentation](#manage-supporting-documentation)
Loading
Loading