-
Notifications
You must be signed in to change notification settings - Fork 4
Add PR previews #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PR previews #307
Conversation
PR SummaryThis pull request introduces several enhancements to the GitHub Actions workflows used in the project. The key changes are as follows:
Test Suggestions
|
Test closing the PR to check if the PR preview gets deleted. |
Deleting worked, see https://github.com/validmind/documentation/actions/runs/10674028315/job/29583896617. Reopening PR. |
PR SummaryThis pull request introduces several enhancements to the GitHub Actions workflows used in the project. The key changes are as follows:
Test Suggestions
|
A PR preview is available: Preview URL |
PR SummaryThis pull request introduces several enhancements to the GitHub Actions workflows used in the project. The key changes are as follows:
Test Suggestions
|
PR SummaryThis pull request introduces several enhancements to the GitHub Actions workflows used in the project. The key changes are as follows:
Test Suggestions
|
Test deleting PR preview by closing PR. |
Reopening PR for review & approval. |
PR SummaryThis pull request introduces several enhancements to the GitHub Actions workflows used in the project. The key changes are as follows:
Test Suggestions
|
A PR preview is available: Preview URL |
Internal Notes for Reviewers
This PR adds automatic previews that
In our docs CI/CD deployment proposal, this PR adds the following highlight:
Proof it works
Deploy PR preview
Successful run: https://github.com/validmind/documentation/actions/runs/10673952942
Delete PR preview
Successful run https://github.com/validmind/documentation/actions/runs/10674028315
How it works
We already had a check to render the docs site and run tests. Together with a bit of editing of the existing workflow, we now basically take the output of that
quarto render
step and sync it to AWS S3, making it an efficient solution to deploy PR previews.Why not a separate workflow to deploy PR previews? The existing quarto render CI check gives us everything we need and is also the most expensive check to run, taking ~5 minutes to complete.
The PR preview delete is just the
aws s3 rm
command performed on the same path in the docs-demo S3 bucket. The delete is silent as it's not something an author or reviewer needs to engage with — failures in the action should result in an email from GitHub.How to test
Validate docs site (render, test, and deploy)
CI check. Use the preview URL from the comment to check the preview is there.Delete PR preview
action to run, recheck the preview URL (it should 404), and then reopen this PRExternal Release Notes