-
Notifications
You must be signed in to change notification settings - Fork 4
Updated docs for validation guideline settings #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated docs for validation guideline settings #274
Conversation
Nik: Oops, don't know how I removed the review. Sorry for the double-notif. 🫠 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will approve after you make the requested changes.
Why I marked this as Request changes
:
-
Numbered steps without a clear task heading feels like saying 'here, do these steps' without also telling you what the steps do. I’d ask that we avoid or discuss why we should allow this approach in our docs.
-
Let's agree not to explain how the UI works, something
click X to cancel
does not belong. The suggestions I included to delete the text also required reworking some of the surrounding text, but please check I got them right.
Other comments:
-
References to things you perform actions on should be in the plural in headings, e.g.
#### Add guidelines
with an "s" at the end, similar to what you already had for risk areas. -
The
After you confirm ...
additions that show up in the training modules feel especially useful, thank you! It's a small change but it works really well, IMHO.
site/guide/configuration/_set-up-your-organization-risk-areas.qmd
Outdated
Show resolved
Hide resolved
site/guide/configuration/_set-up-your-organization-risk-areas.qmd
Outdated
Show resolved
Hide resolved
PR SummaryThis pull request introduces several enhancements and fixes to the documentation and configuration guidelines within the project. The key changes include:
Test Suggestions
|
Agreed, I think I started adding some lead-in text but didn't for this PR for some reason.
I think for this I'm a little torn — sometimes talking around the behaviour sounds way more awkward than describing the behaviour. In this case, isn't "Click x to action" describing a task? How would you word it instead?
I forget why I had this in the singular, I feel like I had a reason but after looking at it again it doesn't seem right LOL |
e7cf803
to
5cb6b5b
Compare
It was too confusing for me to look at the commit suggestions when pulled down without seeing the full context so I'm just going to redo them manually; sorry! |
PR SummaryThis pull request introduces several enhancements and new content to the documentation:
Key Changes
Test Suggestions
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Reviewed the changes based on your latest screenshots and then also spot tested one of the tasks ("Add guidelines to template") — worked perfectly. 🚀🚀🚀
Internal Notes for Reviewers
Preparing validation reports
Get started
section into more accurate instructions on how to interact with validation reports, including information on viewing validation guidelines (I decided this did not need to be its own page or even section, as they are pretty well integrated into the report building process)What's next
included all the other pages under this landingView validation guidelines > Manage validation guidelines
model-validation
section and placed it above preparing reports as guidelines should ideally be set before reports are madeCustomize documentation templates
Edit template outline
section to include information on how to expand sections & add content to validation report templatesSet up your organization
Risk areas
section to the bottom and linked out tomanage-validation-guidelines.qmd
insteadset-up-your-organization.qmd
single-sourcing files as well to match this format and made sure they look OK in the training as wellOther cleanup
Listings & What's next
What's next
section of some articles to be more relevant or comprehensiveExamples:
Unified display of
+
&x
+
signs orcircle-plus
icons to theplus
icon where appropriate (making sure it matched what was in the UI).x
to the FAx
icon insteadExample: