Skip to content

Fix nlp and llm path in output #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Conversation

nrichers
Copy link
Collaborator

@nrichers nrichers commented Aug 9, 2024

Internal Notes for Reviewers

When I reviewed #267, I checked the site/ source path was correct. I did not check the site/_site output path and, lo and behold, it's still cased incorrectly on main. This PR fixes that issue, hopefully once and for all.

External Release Notes

@nrichers nrichers added the internal Not to be externalized in the release notes label Aug 9, 2024
@nrichers nrichers requested a review from validbeck August 9, 2024 16:12
Copy link
Contributor

github-actions bot commented Aug 9, 2024

PR Summary

This pull request removes several generated HTML files from the repository. These files are located in the site/_site/notebooks/code_samples/nlp_and_llm/ directory and include various demo files related to NLP and LLM integrations and summarizations. The removal of these files helps to keep the repository clean and reduces unnecessary clutter from generated content.

Test Suggestions

  • Verify that the repository builds successfully without the removed HTML files.
  • Ensure that the documentation generation process correctly regenerates the removed HTML files if needed.
  • Check that no references to the removed HTML files exist in the codebase or documentation.

@nrichers
Copy link
Collaborator Author

nrichers commented Aug 9, 2024

This pull request removes several generated HTML files from the repository. These files are located in the site/_site/notebooks/code_samples/nlp_and_llm/ directory and include various demo files related to NLP and LLM integrations and summarizations. The removal of these files helps to keep the repository clean and reduces unnecessary clutter from generated content.

Interesting that the bot gets this quite wrong, given that it's clearly a rename and not a delete.

image

Copy link
Collaborator

@validbeck validbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me — did you just directly rename the output folder?

@nrichers
Copy link
Collaborator Author

nrichers commented Aug 9, 2024

Looks good to me — did you just directly rename the output folder?

Two-step rename, as before. Seems safest.

@nrichers nrichers merged commit 5f9d3f3 into main Aug 9, 2024
5 checks passed
@nrichers nrichers deleted the fix-nlp-and-llm-path-in-output branch August 9, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Not to be externalized in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants