-
Notifications
You must be signed in to change notification settings - Fork 4
Got rid of site unused #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, but we should wait for Nik to look just in case!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we agree that nothing should live in site/
that isn't part of the public site?
For this PR, I think this means moving /site/wip
up a level or deleting. I know search is set to false for these files, but there's no reason to build and externalize them at all, as they are just old cruft.
(I'd be fine with going one step further and just deleting that wip
folder. All of the content in there is experimental from last year and largely defunct in its current form.)
Fine by me! I just wasn't sure if you had any plans for the stuff in there that felt more fleshed out. I think I will keep the mermaid diagrams and put it into templates as a reference but otherwise I'm good with nixing the rest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
35057ef
to
9556bdb
Compare
Internal Notes for Reviewers
Things moved
WIP
site/wip
(search
set tofalse
). These were either upcoming product docs that had a nice skeleton or some conceptual docs we might want to revisit.@nrichers Let me know if you'd prefer to unthink-therefore-unam these bad boys and we can do that:
conceptual
product
mermaid-diagrams-dev-framework.qmd
editions-and-features.qmd
(Refer to Slack conversation here.)mrm-lifecycle.qmd
mrm-three-lines-of-defense.qmd
mrm.qmd
/internal
Slight edits
/faq/faq-privacy.qmd
page as there was one line from the duplicate file not present on this surfaced filerelease-notes.qmd
for2024-may-22
so I resolved thateditions-and-features.qmd
file and found that the.column-screen-inset-right
didn't actually look too great so I removed it/internal/testing.qmd
(theinternal
folder OUTSIDE ofsite
instead of into the now non-existingsite-unused
)Comparisons
*Just my VSCode preview theming, not to worry about the red.