Skip to content

Got rid of site unused #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 7, 2024
Merged

Got rid of site unused #261

merged 10 commits into from
Aug 7, 2024

Conversation

validbeck
Copy link
Collaborator

@validbeck validbeck commented Aug 1, 2024

Internal Notes for Reviewers

For sc-5565, I got rid of our site-unused folder.

Things moved

WIP

File tree Description
Screenshot 2024-08-01 at 10 02 10 AM Anything I didn't delete ended up in site/wip (search set to false). These were either upcoming product docs that had a nice skeleton or some conceptual docs we might want to revisit.

@nrichers Let me know if you'd prefer to unthink-therefore-unam these bad boys and we can do that:

conceptual product
mermaid-diagrams-dev-framework.qmd editions-and-features.qmd (Refer to Slack conversation here.)
mrm-lifecycle.qmd
mrm-three-lines-of-defense.qmd
mrm.qmd
  • It feels like the MRM ones are a bit covered in the glossary, but we should still think about expanding these "beginner" guides to make good on our claim of wanting to be an MRM authority, IMO.
  • Mermaid diagram one might be good to be moved into templates, just so we know how to structure diagrams in the future.

/internal

New top-level (above site) folder for templates and testing (samples and examples moved from site/internal when done)

Slight edits

Comparisons

Old New
File tree Screenshot 2024-08-01 at 10 00 01 AM Screenshot 2024-08-01 at 9 53 12 AM
README Screenshot 2024-08-01 at 10 00 22 AM Screenshot 2024-08-01 at 9 57 52 AM*

*Just my VSCode preview theming, not to worry about the red.

@validbeck validbeck added the internal Not to be externalized in the release notes label Aug 1, 2024
@validbeck validbeck self-assigned this Aug 1, 2024
@validbeck validbeck marked this pull request as ready for review August 1, 2024 17:21
@validbeck validbeck requested review from nrichers and noosheenv August 1, 2024 17:21
Copy link
Contributor

@noosheenv noosheenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, but we should wait for Nik to look just in case!

Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we agree that nothing should live in site/ that isn't part of the public site?

For this PR, I think this means moving /site/wip up a level or deleting. I know search is set to false for these files, but there's no reason to build and externalize them at all, as they are just old cruft.

(I'd be fine with going one step further and just deleting that wip folder. All of the content in there is experimental from last year and largely defunct in its current form.)

@validbeck
Copy link
Collaborator Author

For this PR, I think this means moving /site/wip up a level or deleting. I know search is set to false for these files, but there's no reason to build and externalize them at all, as they are just old cruft.

Fine by me! I just wasn't sure if you had any plans for the stuff in there that felt more fleshed out. I think I will keep the mermaid diagrams and put it into templates as a reference but otherwise I'm good with nixing the rest.

@validbeck validbeck requested a review from nrichers August 6, 2024 22:36
Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@validbeck validbeck force-pushed the beck/sc-5565/get-rid-of-site-unused branch from 35057ef to 9556bdb Compare August 7, 2024 00:08
@validbeck validbeck merged commit 652f8cd into main Aug 7, 2024
3 checks passed
@validbeck validbeck deleted the beck/sc-5565/get-rid-of-site-unused branch August 7, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Not to be externalized in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants