-
Notifications
You must be signed in to change notification settings - Fork 4
Add Private Service Connect & rework login info #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nrichers
merged 14 commits into
main
from
nrichers/sc-4434/documentation-complete-bny-account-setup
Jul 18, 2024
Merged
Add Private Service Connect & rework login info #251
nrichers
merged 14 commits into
main
from
nrichers/sc-4434/documentation-complete-bny-account-setup
Jul 18, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc-4434/documentation-complete-bny-account-setup
Nik and I reviewed this in a meeting and it looks good. Thanks Nik! |
sc-4434/documentation-complete-bny-account-setup
@noosheenv could you review this PR from the angle of 'do the reworked step 1 instructions work and did Nik break anything (again)', please? Spencer already reviewed for technical accuracy. |
Sanity tested these PR changes further:
This looks to be OK, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal Notes for Reviewers
Highlights of this PR:
Private Service Connect
Added topic for configuring Google Cloud Private Service Connect:
_variables.yml
To reflect that there are now multiple production login URLs:
Split
vm_url
intovm_url_us1
andvm_url_ca1
.vm_url
: "https://app.prod.validmind.ai"vm_url_us1
: "https://app.prod.validmind.ai"vm_url_ca1
: "https://app.ca1.validmind.ai"Removed
vm_login
variable as no longer applicable in a multi-production sites worldStep 1 in task topics
To enable a log in step at the beginning of task topics that works for multiple production URLs:
Re-added login topic, now updated with info about public and private URL info about accessing the ValidMind Platform UI
Replaced step 1 in task topics with login link to point to login topic instead of platform UI URL
CTAs, training, and other links
vm_url_us1
variable (it's the same URL we've always sent people to)vm_url_us1
(training modules are unchanged and use HTML links that point to the same URL)vm_url_us1
as the defaultStale content
In an effort not to maintain content that is defunct:
guide/get-started-sandbox.qmd
file as it's been superseded by our ValidMind Academy contentsite-unused/qmd/get-started-closed-beta.qmd
file as we're done with the beta nowOpen items
As an experiment, is there a step 1 option that feels more elegant? >>> TO BE MOVED INTO A SEPARATE PR
With Nutshell, via a single-sourced step-1.qmd:
Notes
_
or the extension does not work, meaning there will be a separate step-1.html output topicOverall, I'm not sure it's an improvement over linking to the login topic.
With
citationshover: true
we could do something like this:Notes
For links that default to using
vm_url_us1
, will users be able to log in? Need to verify with Spencer.External Release Notes
Release Notes
We've introduced support for Google Cloud Private Service Connect for enhanced network security and privacy, in addition to the already existing support for AWS PrivateLink. This service allows private connections between ValidMind and your company network, ensuring secure communication over the Google network without exposing traffic to the public internet. By using private endpoints within your VPC, you can reduce your network's attack surface and maintain traffic privacy. Read more ...