Skip to content

Initial Matrix-style 404 page #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 3, 2024
Merged

Initial Matrix-style 404 page #231

merged 10 commits into from
Jul 3, 2024

Conversation

nrichers
Copy link
Collaborator

@nrichers nrichers commented Jun 27, 2024 •
edited
Loading

Internal Notes for Reviewers

This is PR includes and initial 404 error page based on our afternoon hackathon.

2024-06-28_16-36-25 (3)

External Release Notes

@validbeck
Copy link
Collaborator

validbeck commented Jun 28, 2024 •
edited
Loading

I stole the code I used to build the placeholder pages and just plunked it onto this one with some quick modifications:

Screenshot 2024-06-28 at 3 27 11 PM

@validbeck
Copy link
Collaborator

Screenshot 2024-06-28 at 4 18 15 PM

@nrichers nrichers requested review from noosheenv and validbeck June 28, 2024 23:43
validbeck
validbeck approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@validbeck validbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for a V1 for me :)

@nrichers nrichers merged commit 030a5cb into main Jul 3, 2024
1 of 2 checks passed
@nrichers nrichers deleted the 404-hackathon branch July 3, 2024 20:13
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Pull requests must include at least one of the required labels: internal, highlight, enhancement, bug, deprecation, documentation. Except for internal, pull requests must also include a description in the release notes section.

@nrichers nrichers added the internal Not to be externalized in the release notes label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@validbeck validbeck validbeck approved these changes

@noosheenv noosheenv Awaiting requested review from noosheenv

Assignees
No one assigned
Labels
internal Not to be externalized in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nrichers @validbeck