Skip to content

Updated test descriptions #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 2, 2024
Merged

Updated test descriptions #229

merged 7 commits into from
Jul 2, 2024

Conversation

nrichers
Copy link
Collaborator

@nrichers nrichers commented Jun 26, 2024

Internal Notes for Reviewers

This PR pulls in Andres' fix from validmind/validmind-library#124 for empty test descriptions.

To make sure that we do not lose our current executed intro notebook for developers, I also added a step to make get-source to check out the existing notebook from main.

Output

This PR has been deployed to the docs-demo site for testing: https://docs-demo.vm.validmind.ai/guide/test-descriptions.html

External Release Notes

We fixed a number of missing test descriptions that were caused by a scripting issue. Test descriptions

@nrichers nrichers added DO NOT MERGE PR is not ready to be merged internal Not to be externalized in the release notes labels Jun 26, 2024
@nrichers nrichers changed the title Test descriptions Updated test descriptions Jul 2, 2024
@nrichers nrichers requested a review from validbeck July 2, 2024 20:18
@nrichers nrichers added bug Something isn't working and removed DO NOT MERGE PR is not ready to be merged internal Not to be externalized in the release notes labels Jul 2, 2024
Copy link
Collaborator

@validbeck validbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It looks good to me and I don't see any issues on a spot check. 🎉

@nrichers nrichers merged commit 39d9427 into main Jul 2, 2024
2 checks passed
@nrichers nrichers deleted the test-andres-descriptions-pr branch July 2, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants