Skip to content

Validmind-226 SR 25May #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 25, 2024
Merged

Validmind-226 SR 25May #201

merged 6 commits into from
May 25, 2024

Conversation

subatraSR2
Copy link
Contributor

Internal Notes for Reviewers

Committed updates for the below-related documentation.

https://github.com/validmind/frontend/pull/643 - [VALIDMIND-161] Add Business Units from the organization settings page
added info on business units - create new but added edit and delete as well
[VALIDMIND-180] Remove Business Units from the organization settings page. #680
https://github.com/validmind/frontend/pull/652 - [VALIDMIND-163] Add Risk Areas from the Organization settings page
Added info on how to create new business risk area and remove any risk area.
https://github.com/validmind/frontend/pull/658 feat: add business unit and risk area at organization setting

Add and Remove Use Cases #693
https://github.com/validmind/frontend/pull/693

[VALIDMIND-238] Delete group #690
https://github.com/validmind/frontend/pull/690

https://github.com/validmind/frontend/pull/728 - feat: add, remove, and rename sections with the new template editing experience #728
Also includes [VALIDMIND-188 Reposition sections in a template]
https://github.com/validmind/frontend/pull/692 feat: remove a section from a template

External Release Notes

@CLAassistant
Copy link

CLAassistant commented May 24, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

Pull requests must include at least one of the required labels: internal, highlight, enhancement, bug, deprecation, documentation. Except for internal, pull requests must also include a description in the release notes section.

Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰 Reshuffled the Edit and Raw Edit sections and fixed the merge conflicts. Nice work — these docs are on point.

@@ -7,7 +7,7 @@ Edit templates that get used for model documentation or for validation reports t

## About documentation templates

Documentation templates are stored as YAML files that you edit directly in the online editor. These templates are versioned and saving a documentation template after making changes or reverting to a previous version state always creates a new version.
Documentation templates are stored as YAML files that you can edit directly in the online editor using the **Edit Raw** button. We also provide an enhanced editing experience, use the simpler **Edit** button. These templates are versioned and saving a documentation template after making changes or reverting to a previous version state always creates a new version.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Documentation templates are stored as YAML files that you can edit directly in the online editor using the **Edit Raw** button. We also provide an enhanced editing experience, use the simpler **Edit** button. These templates are versioned and saving a documentation template after making changes or reverting to a previous version state always creates a new version.
Documentation templates are stored as YAML files that you can edit directly in the online editor using the **Edit Raw** button. We also provide an enhanced, simpler editing experience with the **Edit** button. These templates are versioned and saving a documentation template after making changes or reverting to a previous version state always creates a new version.

@nrichers nrichers added the internal Not to be externalized in the release notes label May 25, 2024
@nrichers nrichers merged commit 9ec26cf into main May 25, 2024
@nrichers nrichers deleted the validmind226_pt1 branch May 25, 2024 00:31
@subatraSR2 subatraSR2 changed the title Validming-226 SR 25May WIP Validmind-226 SR 25May WIP May 27, 2024
@nrichers nrichers changed the title Validmind-226 SR 25May WIP Validmind-226 SR 25May Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Not to be externalized in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants