-
Notifications
You must be signed in to change notification settings - Fork 4
Created "Manage model inventory custom fields" page in Guides #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created "Manage model inventory custom fields" page in Guides #199
Conversation
noosheen vazinkhoo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
noosheen vazinkhoo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@nrichers Just a quick change to the page to add a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after comments are addressed. A few suggestions relate to tech writing best practices — e.g. explaining the user action rather than UI behavior — let me know if you want to chat more about these.
One other, small comment: I would put "Register models in the inventory" first — pushed ab7323e to that effect. ![]() |
ab7323e
to
b96ae46
Compare
@nrichers I adjusted these changes locally then pushed them instead as I had to accommodate for Rod's quick work on PR-#771 as well! EDIT: Currently live on the demo-site: https://docs-demo.vm.validmind.ai/guide/manage-inventory-custom-fields.html |
FYI, copying changes manually and force pushing should not be necessary — just do a |
Oh yeah, I had just made changes before I saw your contributions so I already had a divergence 💀 |
One of the hallmarks of git & GitHub is decentralized collaboration, so resolving divergence is as simple as merging in changes. It's literally what the thing was made for. Great talk by Linus Torvalds on the motivation behind git: https://youtu.be/idLyobOhtO4?si=3pZvZe9LKjTJgSlA |
Internal Notes for Reviewers
Manage model inventory custom fields
Manage inventory custom fields
Guides:
Added the new

Manage model inventory custom fields
page to the listings: