Skip to content

Added "Documentation section" info on Work with model findings #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

validbeck
Copy link
Collaborator

Internal Notes for Reviewers

For sc-3969, I adjusted Work with model findings.

Add project findings

Broke down the "Add project findings" section into two sub-sections:

  1. Add finding via overview
  2. Add finding via section
Old New
Screenshot 2024-05-21 at 10 41 26 AM Screenshot 2024-05-21 at 10 41 10 AM

Update project findings

Added - Documentation section to the list of items you can make updates to under the "Update project findings" section.

Old New
Screenshot 2024-05-21 at 10 43 31 AM Screenshot 2024-05-21 at 10 43 25 AM

@validbeck validbeck added the internal Not to be externalized in the release notes label May 21, 2024
@validbeck validbeck self-assigned this May 21, 2024
@validbeck validbeck requested a review from nrichers May 21, 2024 17:45
Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit: One minor comment about formatting & grammar but looks great otherwise.

@validbeck validbeck merged commit 304209f into main May 22, 2024
2 checks passed
@validbeck validbeck deleted the beck/sc-3969/documentation-add-documentation-section-field branch May 22, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Not to be externalized in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants