Skip to content

Fixing broken links in integrate_external_test_providers.ipynb #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

noosheenv
Copy link
Contributor

Internal Notes for Reviewers

  • I brought in the changes from the developer-framework repo into documentation using make get-source and quarto preview/render
  • the changes: implementing -> implement and its variants
  • see PR 91 on developer-framework for more details.

External Release Notes

@noosheenv noosheenv added the internal Not to be externalized in the release notes label May 17, 2024
@noosheenv noosheenv requested a review from validbeck May 17, 2024 23:38
@noosheenv noosheenv self-assigned this May 17, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


noosheen vazinkhoo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@validbeck validbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! And now you know what make get-source does. :)

@validbeck
Copy link
Collaborator

@noosheenv I'm going to go ahead and merge this into main so we can proceed with publishing this change to the docs site while you're out today (May 21, 2024) so it stops reverting! Nice work. :)

@validbeck validbeck merged commit c93d31b into main May 21, 2024
2 of 3 checks passed
@validbeck validbeck deleted the noosheenvazinkhoo/sc-4382/resolve-broken-links-in-integrate-external branch May 21, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Not to be externalized in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants